Fix bug: calling mutation from unmounted component

lorensr · lorensr · commit f2efdd8b2d3a · 2019-03-22T01:14:37.000-04:00
diff --git a/src/components/Section.js b/src/components/Section.js
@@ -15,7 +15,7 @@ class Section extends Component {
       return
     }
 
-    setTimeout(() => {
+    this.timeoutID = setTimeout(() => {
       this.props.viewedSection({
         variables: { id }
       })
@@ -36,6 +36,7 @@ class Section extends Component {
   }
 
   componentWillUnmount() {
+    clearTimeout(this.timeoutID)
     window.removeEventListener('scroll', this.handleScroll)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ class Section extends Component {`
`15`	`15`	`return`
`16`	`16`	`}`
`17`	`17`
`18`		`- setTimeout(() => {`
	`18`	`+ this.timeoutID = setTimeout(() => {`
`19`	`19`	`this.props.viewedSection({`
`20`	`20`	`variables: { id }`
`21`	`21`	`})`
`@@ -36,6 +36,7 @@ class Section extends Component {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`componentWillUnmount() {`
	`39`	`+ clearTimeout(this.timeoutID)`
`39`	`40`	`window.removeEventListener('scroll', this.handleScroll)`
`40`	`41`	`}`
`41`	`42`