Skip to content

Commit 31d95fd

Browse files
sharmilajesupaulljharb
authored andcommitted
[eslint config] [*] [deps] update eslint, eslint-plugin-import, eslint-find-rules
1 parent 06e2899 commit 31d95fd

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

packages/eslint-config-airbnb-base/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,16 +52,16 @@
5252
"babel-preset-airbnb": "^2.4.0",
5353
"babel-tape-runner": "^2.0.1",
5454
"editorconfig-tools": "^0.1.1",
55-
"eslint": "^4.18.1",
56-
"eslint-find-rules": "^3.2.0",
57-
"eslint-plugin-import": "^2.9.0",
55+
"eslint": "^4.19.1",
56+
"eslint-find-rules": "^3.2.2",
57+
"eslint-plugin-import": "^2.10.0",
5858
"in-publish": "^2.0.0",
5959
"safe-publish-latest": "^1.1.1",
6060
"tape": "^4.9.0"
6161
},
6262
"peerDependencies": {
63-
"eslint": "^4.18.1",
64-
"eslint-plugin-import": "^2.9.0"
63+
"eslint": "^4.19.1",
64+
"eslint-plugin-import": "^2.10.0"
6565
},
6666
"engines": {
6767
"node": ">= 4"

packages/eslint-config-airbnb-base/rules/imports.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,11 @@ module.exports = {
226226
// https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-self-import.md
227227
'import/no-self-import': 'error',
228228

229+
// Forbid cyclical dependencies between modules
230+
// https://github.com/benmosher/eslint-plugin-import/blob/d81f48a2506182738409805f5272eff4d77c9348/docs/rules/no-cycle.md
231+
// TODO: enable, semver-major
232+
'import/no-cycle': ['off', { maxDepth: Infinity }],
233+
229234
// Ensures that there are no useless path segments
230235
// https://github.com/benmosher/eslint-plugin-import/issues/1032
231236
'import/no-useless-path-segments': 'error',

packages/eslint-config-airbnb/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@
5757
"babel-preset-airbnb": "^2.4.0",
5858
"babel-tape-runner": "^2.0.1",
5959
"editorconfig-tools": "^0.1.1",
60-
"eslint": "^4.18.1",
61-
"eslint-find-rules": "^3.2.0",
62-
"eslint-plugin-import": "^2.9.0",
60+
"eslint": "^4.19.1",
61+
"eslint-find-rules": "^3.2.2",
62+
"eslint-plugin-import": "^2.10.0",
6363
"eslint-plugin-jsx-a11y": "^6.0.3",
6464
"eslint-plugin-react": "^7.7.0",
6565
"in-publish": "^2.0.0",
@@ -68,8 +68,8 @@
6868
"tape": "^4.9.0"
6969
},
7070
"peerDependencies": {
71-
"eslint": "^4.18.1",
72-
"eslint-plugin-import": "^2.9.0",
71+
"eslint": "^4.19.1",
72+
"eslint-plugin-import": "^2.10.0",
7373
"eslint-plugin-jsx-a11y": "^6.0.3",
7474
"eslint-plugin-react": "^7.7.0"
7575
},

0 commit comments

Comments
 (0)