Skip to content

Commit bb6e5d2

Browse files
committed
Fix CJUnitTestsPort CTest path
1 parent 0864821 commit bb6e5d2

File tree

3 files changed

+27
-33
lines changed

3 files changed

+27
-33
lines changed

test/CJUnitTestsPort/CMakeLists.txt

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ ENDIF(MYSQLCPPCONN_TEST_NOT_IMPLEMENTED)
4949

5050
INCLUDE_DIRECTORIES("${CMAKE_BINARY_DIR}/include/jdbc")
5151

52-
SET(jdbctests_sources
52+
SET(test_CJUnitTestsPort_sources
5353
ccpptests.cpp
5454
BaseTestFixture.cpp
5555
../common/stringutils.cpp
@@ -70,8 +70,8 @@ SET(jdbctests_sources
7070

7171
# It's convinient for VS users to have headers as part of project
7272
IF(WIN32)
73-
SET(jdbctests_sources
74-
${jdbctests_sources}
73+
SET(test_CJUnitTestsPort_sources
74+
${tests_CJUnitTestsPort_sources}
7575
BaseTestFixture.h
7676
../common/stringutils.h
7777
resources.h
@@ -90,12 +90,7 @@ IF(WIN32)
9090
)
9191
ENDIF(WIN32)
9292

93-
ADD_EXECUTABLE(CJUnitTestsPort ${jdbctests_sources})
94-
TARGET_LINK_LIBRARIES(CJUnitTestsPort ${MY_TARGET_LINK_LIBRARIES} ${MY_GCOV_LINK_LIBRARIES})
95-
96-
set_target_properties(CJUnitTestsPort PROPERTIES FOLDER "Tests/jdbc")
97-
98-
ADD_TEST(NAME jdbc_CJUnitTestsPort COMMAND CJUnitTestsPort)
93+
add_unit_test(CJUnitTestsPort)
9994

10095
#Copy sql.properties file to build dir
10196
file(COPY sql.properties DESTINATION ${CMAKE_CURRENT_BINARY_DIR})

test/CMakeLists.txt

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,29 @@ TARGET_LINK_LIBRARIES(driver_test ${MY_TARGET_LINK_LIBRARIES} ${MY_GCOV_LINK_LIB
8787
#TODO: Check if this test should be added since it is failing!
8888
#ADD_TEST(NAME jdbc_driver_test COMMAND driver_test)
8989

90+
function(add_unit_test NAME)
91+
92+
if (ARGN)
93+
list(GET ARGN 0 TGT_NAME)
94+
else()
95+
set(TGT_NAME test_${NAME})
96+
endif()
97+
98+
ADD_EXECUTABLE(${TGT_NAME} ${test_${NAME}_sources})
99+
SET_TARGET_PROPERTIES(${TGT_NAME} PROPERTIES
100+
OUTPUT_NAME "${NAME}"
101+
LINK_FLAGS "${MYSQLCPPCONN_LINK_FLAGS_ENV} ${MYSQL_LINK_FLAGS}"
102+
COMPILE_FLAGS "${MYSQLCPPCONN_COMPILE_FLAGS_ENV}"
103+
FOLDER "Tests/jdbc"
104+
)
105+
TARGET_LINK_LIBRARIES(${TGT_NAME} ${MY_TARGET_LINK_LIBRARIES} ${MY_GCOV_LINK_LIBRARIES})
106+
107+
ADD_TEST(NAME jdbc_test_${NAME} COMMAND $<TARGET_FILE_NAME:${TGT_NAME}>)
108+
109+
MESSAGE(STATUS "Configuring unit tests - ${NAME}")
110+
111+
endfunction()
112+
90113
MESSAGE(STATUS "Configuring test cases")
91114

92115
add_subdirectory(CJUnitTestsPort)

test/unit/CMakeLists.txt

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -104,30 +104,6 @@ IF(MYSQLCPPCONN_TEST_NOT_IMPLEMENTED)
104104
ENDIF(MYSQLCPPCONN_TEST_NOT_IMPLEMENTED)
105105

106106

107-
function(add_unit_test NAME)
108-
109-
if (ARGN)
110-
list(GET ARGN 0 TGT_NAME)
111-
else()
112-
set(TGT_NAME test_${NAME})
113-
endif()
114-
115-
ADD_EXECUTABLE(${TGT_NAME} ${test_${NAME}_sources})
116-
SET_TARGET_PROPERTIES(${TGT_NAME} PROPERTIES
117-
OUTPUT_NAME "${NAME}"
118-
LINK_FLAGS "${MYSQLCPPCONN_LINK_FLAGS_ENV} ${MYSQL_LINK_FLAGS}"
119-
COMPILE_FLAGS "${MYSQLCPPCONN_COMPILE_FLAGS_ENV}"
120-
FOLDER "Tests/jdbc"
121-
)
122-
TARGET_LINK_LIBRARIES(${TGT_NAME} ${MY_TARGET_LINK_LIBRARIES} ${MY_GCOV_LINK_LIBRARIES})
123-
124-
ADD_TEST(NAME jdbc_test_${NAME} COMMAND $<TARGET_FILE_NAME:${TGT_NAME}>)
125-
126-
MESSAGE(STATUS "Configuring unit tests - ${NAME}")
127-
128-
endfunction()
129-
130-
131107
MESSAGE(STATUS "Configuring unit tests")
132108

133109
ADD_SUBDIRECTORY(example/)

0 commit comments

Comments
 (0)