Fix int overflow and UT failure on GCC 12 (Fedora 36)

Change-Id: I7a5a1f5c8a623b8931803ffd27503ddab7d41ba3

Change-Id: Iba467a4a357012e37ab9b516f989f91f8dc6769b

Author: silvakid

driver/mysql_art_resultset.cpp

@@ -257,26 +257,31 @@ MySQL_ArtResultSet::isBeforeFirstOrAfterLast() const
 }
 /* }}} */
 
+/* {{{ MySQL_ArtResultSet::absolute() -I-
+  _new_pos: Seek the passed position on the ResultSet. If _new_pos is negative,
+            it will count from last to beginning.
 
-/* {{{ MySQL_ArtResultSet::absolute() -I- */
+  return: true if position is a valid row, false if it pasted last or beginnin
+*/
 bool
-MySQL_ArtResultSet::absolute(const int row)
+MySQL_ArtResultSet::absolute(const int _row)
 {
   CPP_ENTER("MySQL_ArtResultSet::absolute");
   checkValid();
+  const int64_t row = _row;
   if (row > 0) {
-    if (row > (int) num_rows) {
+    if (row > num_rows) {
       afterLast();
     } else {
       row_position = row;
       seek();
       return true;
     }
   } else if (row < 0) {
-    if ((-row) > (int) num_rows) {
+    if (-row > num_rows) {
       beforeFirst();
     } else {
-      row_position = num_rows - (-row)  + 1;
+      row_position = num_rows + row + 1;
       seek();
       return true;
     }

driver/mysql_ps_resultset.cpp

@@ -126,27 +126,33 @@ MySQL_Prepared_ResultSet::~MySQL_Prepared_ResultSet()
 }
 /* }}} */
 
+/* {{{ MySQL_Prepared_ResultSet::absolute() -I-
+  _new_pos: Seek the passed position on the ResultSet. If _new_pos is negative,
+            it will count from last to beginning.
 
-/* {{{ MySQL_Prepared_ResultSet::absolute() -I- */
+  return: true if position is a valid row, false if it pasted last or beginnin
+*/
 bool
-MySQL_Prepared_ResultSet::absolute(const int new_pos)
+MySQL_Prepared_ResultSet::absolute(const int _new_pos)
 {
     CPP_ENTER("MySQL_Prepared_ResultSet::absolute");
     checkValid();
     checkScrollable();
-    if (new_pos > 0) {
-        if (new_pos > (int) num_rows) {
+    const int64_t new_pos = _new_pos;
+    if (new_pos > 0)
+    {
+        if (new_pos > num_rows) {
             row_position = num_rows + 1; /* after last row */
         } else {
             row_position = new_pos;
             seek();
             return true;
         }
     } else if (new_pos < 0) {
-        if ((-new_pos) > (int) num_rows || (new_pos == std::numeric_limits<int>::min())) {
+        if (-new_pos > num_rows) {
             row_position = 0; /* before first new_pos */
         } else {
-            row_position = num_rows - (-new_pos) + 1;
+            row_position = num_rows + new_pos + 1;
             seek();
             return true;
         }

driver/mysql_resultset.cpp

@@ -95,26 +95,32 @@ MySQL_ResultSet::~MySQL_ResultSet()
 /* }}} */
 
 
-/* {{{ MySQL_ResultSet::absolute() -I- */
+/* {{{ MySQL_ResultSet::absolute() -I-
+  _new_pos: Seek the passed position on the ResultSet. If _new_pos is negative,
+            it will count from last to beginning.
+
+  return: true if position is a valid row, false if it pasted last or beginnin
+*/
 bool
-MySQL_ResultSet::absolute(const int new_pos)
+MySQL_ResultSet::absolute(const int _new_pos)
 {
     CPP_ENTER("MySQL_ResultSet::absolute");
     checkValid();
     checkScrollable();
+    const int64_t new_pos = _new_pos;
     if (new_pos > 0) {
-        if (new_pos > (int) num_rows) {
+        if (new_pos > num_rows) {
             row_position = num_rows + 1; /* after last row */
         } else {
-            row_position = (my_ulonglong) new_pos; /* the cast is inspected and is valid */
+            row_position = new_pos;
             seek();
             return true;
         }
     } else if (new_pos < 0) {
-        if ((-new_pos) > (int) num_rows || (new_pos == std::numeric_limits<int>::min())) {
+        if ((-new_pos) > num_rows) {
             row_position = 0; /* before first new_pos */
         } else {
-            row_position = num_rows - (-new_pos)  + 1;
+            row_position = num_rows + new_pos + 1;
             seek();
             return true;
         }