WeAreSorryHubBase - bringing HubBase back to fix binary compatibility

Fixes SignalR#3489

Author: moozzyk

src/Microsoft.AspNet.SignalR.Core/Hub.cs

@@ -8,68 +8,18 @@ namespace Microsoft.AspNet.SignalR
     /// <summary>
     /// Provides methods that communicate with SignalR connections that connected to a <see cref="Hub"/>.
     /// </summary>
-    public abstract class Hub : IHub
+    public abstract class Hub : HubBase
     {
-        protected Hub()
+        public IHubCallerConnectionContext<dynamic> Clients
         {
-            Clients = new HubConnectionContext();
-        }
-
-        /// <summary>
-        /// Gets a dynamic object that represents all clients connected to this hub (not hub instance).
-        /// </summary>
-        public IHubCallerConnectionContext<dynamic> Clients { get; set; }
-
-        /// <summary>
-        /// Provides information about the calling client.
-        /// </summary>
-        public HubCallerContext Context { get; set; }
-
-        /// <summary>
-        /// The group manager for this hub instance.
-        /// </summary>
-        public IGroupManager Groups { get; set; }
-
-        /// <summary>
-        /// Called when a connection disconnects from this hub gracefully or due to a timeout.
-        /// </summary>
-        /// <param name="stopCalled">
-        /// true, if stop was called on the client closing the connection gracefully;
-        /// false, if the connection has been lost for longer than the
-        /// <see cref="Configuration.IConfigurationManager.DisconnectTimeout"/>.
-        /// Timeouts can be caused by clients reconnecting to another SignalR server in scaleout.
-        /// </param>
-        /// <returns>A <see cref="Task"/></returns>
-        public virtual Task OnDisconnected(bool stopCalled)
-        {
-            return TaskAsyncHelper.Empty;
-        }
-
-        /// <summary>
-        /// Called when the connection connects to this hub instance.
-        /// </summary>
-        /// <returns>A <see cref="Task"/></returns>
-        public virtual Task OnConnected()
-        {
-            return TaskAsyncHelper.Empty;
-        }
-
-        /// <summary>
-        /// Called when the connection reconnects to this hub instance.
-        /// </summary>
-        /// <returns>A <see cref="Task"/></returns>
-        public virtual Task OnReconnected()
-        {
-            return TaskAsyncHelper.Empty;
-        }
-
-        protected virtual void Dispose(bool disposing)
-        {
-        }
-
-        public void Dispose()
-        {
-            Dispose(true);
+            get
+            {
+                return HubClients;
+            }
+            set
+            {
+                HubClients = value;
+            }
         }
     }
 }

src/Microsoft.AspNet.SignalR.Core/Hubs/HubBase.cs

@@ -0,0 +1,80 @@
+// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved. See License.md in the project root for license information.
+
+using System.Threading.Tasks;
+
+namespace Microsoft.AspNet.SignalR.Hubs
+{
+    /// <summary>
+    /// Provides methods that communicate with SignalR connections that connected to a <see cref="Hub"/>.
+    /// </summary>
+    public abstract class HubBase : IHub
+    {
+        protected HubBase()
+        {
+            HubClients = new HubConnectionContext();
+        }
+
+        internal IHubCallerConnectionContext<dynamic> HubClients { get; set; }
+
+        /// <summary>
+        /// Gets a dynamic object that represents all clients connected to this hub (not hub instance).
+        /// </summary>
+        IHubCallerConnectionContext<dynamic> IHub.Clients
+        {
+            get { return HubClients; }
+            set { HubClients = value; }
+        }
+
+        /// <summary>
+        /// Provides information about the calling client.
+        /// </summary>
+        public HubCallerContext Context { get; set; }
+
+        /// <summary>
+        /// The group manager for this hub instance.
+        /// </summary>
+        public IGroupManager Groups { get; set; }
+
+        /// <summary>
+        /// Called when a connection disconnects from this hub gracefully or due to a timeout.
+        /// </summary>
+        /// <param name="stopCalled">
+        /// true, if stop was called on the client closing the connection gracefully;
+        /// false, if the connection has been lost for longer than the
+        /// <see cref="Configuration.IConfigurationManager.DisconnectTimeout"/>.
+        /// Timeouts can be caused by clients reconnecting to another SignalR server in scaleout.
+        /// </param>
+        /// <returns>A <see cref="Task"/></returns>
+        public virtual Task OnDisconnected(bool stopCalled)
+        {
+            return TaskAsyncHelper.Empty;
+        }
+
+        /// <summary>
+        /// Called when the connection connects to this hub instance.
+        /// </summary>
+        /// <returns>A <see cref="Task"/></returns>
+        public virtual Task OnConnected()
+        {
+            return TaskAsyncHelper.Empty;
+        }
+
+        /// <summary>
+        /// Called when the connection reconnects to this hub instance.
+        /// </summary>
+        /// <returns>A <see cref="Task"/></returns>
+        public virtual Task OnReconnected()
+        {
+            return TaskAsyncHelper.Empty;
+        }
+
+        protected virtual void Dispose(bool disposing)
+        {
+        }
+
+        public void Dispose()
+        {
+            Dispose(true);
+        }
+    }
+}

src/Microsoft.AspNet.SignalR.Core/Microsoft.AspNet.SignalR.Core.csproj

@@ -74,6 +74,7 @@
     <Compile Include="ConnectionConfiguration.cs" />
     <Compile Include="Hosting\INameValueCollection.cs" />
     <Compile Include="Hosting\IResponse.cs" />
+    <Compile Include="Hubs\HubBase.cs" />
     <Compile Include="Hubs\HubInvocationProgress.cs" />
     <Compile Include="Hubs\CallerStateProxy.cs" />
     <Compile Include="Hubs\TypedHubCallerConnectionContext.cs" />