Merge pull request code-dot-org#24853 from code-dot-org/remove-plaintext-email-logging

Remove plaintext user email from HB logging, replace with user ID

Author: Madelyn Kasula

dashboard/app/controllers/omniauth_callbacks_controller.rb

@@ -264,7 +264,7 @@ def silent_takeover(oauth_user, auth_hash)
         # This should never happen if other logic is working correctly, so notify
         Honeybadger.notify(
           error_class: 'Failed to create AuthenticationOption during silent takeover',
-          error_message: "Could not create AuthenticationOption during silent takeover for user with email #{lookup_email}"
+          error_message: "Failed for user with id #{@user.id}"
         )
         return
       end
@@ -280,7 +280,7 @@ def silent_takeover(oauth_user, auth_hash)
         # This should never happen if other logic is working correctly, so notify
         Honeybadger.notify(
           error_class: 'Failed to update User during silent takeover',
-          error_message: "Could not update user during silent takeover for user with email #{lookup_email}"
+          error_message: "Failed for user with id #{@user.id}"
         )
         return
       end

dashboard/app/helpers/users_helper.rb

@@ -82,7 +82,7 @@ def check_and_apply_oauth_takeover(user)
           # We want to know when this fails
           Honeybadger.notify(
             error_class: 'Failed to create AuthenticationOption during signup oauth takeover',
-            error_message: "Could not create AuthenticationOption during signup oauth takeover for user with email #{user.email}"
+            error_message: "Failed for user with id #{user.id}"
           )
         end
       else