Stick to POJO convention

Author: slandelle

api/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java

@@ -94,7 +94,7 @@ public class AsyncHttpClientConfig {
 
     protected boolean compressionEnforced;
     protected String userAgent;
-    protected ExecutorService applicationThreadPool;
+    protected ExecutorService executorService;
     protected Realm realm;
     protected List<RequestFilter> requestFilters;
     protected List<ResponseFilter> responseFilters;
@@ -137,7 +137,7 @@ private AsyncHttpClientConfig(String name,//
             boolean followRedirect, //
             int maxRedirects, //
             boolean strict302Handling, //
-            ExecutorService applicationThreadPool,//
+            ExecutorService executorService,//
             ProxyServerSelector proxyServerSelector, //
             boolean compressionEnforced, //
             String userAgent,//
@@ -184,12 +184,12 @@ private AsyncHttpClientConfig(String name,//
         this.compressionEnforced = compressionEnforced;
         this.userAgent = userAgent;
 
-        if (applicationThreadPool != null) {
-            this.applicationThreadPool = applicationThreadPool;
+        if (executorService != null) {
+            this.executorService = executorService;
         } else {
             PrefixIncrementThreadFactory threadFactory = new PrefixIncrementThreadFactory(
                     getNameOrDefault() + "-");
-            this.applicationThreadPool = Executors.newCachedThreadPool(threadFactory);
+            this.executorService = Executors.newCachedThreadPool(threadFactory);
         }
 
         this.realm = realm;
@@ -375,8 +375,8 @@ public boolean isCompressionEnforced() {
      *         If no {@link ExecutorService} has been explicitly provided, this
      *         method will return <code>null</code>
      */
-    public ExecutorService executorService() {
-        return applicationThreadPool;
+    public ExecutorService getExecutorService() {
+        return executorService;
     }
 
     /**
@@ -494,7 +494,7 @@ public boolean isDisableUrlEncodingForBoundRequests() {
     public boolean isValid() {
         boolean atpRunning = true;
         try {
-            atpRunning = applicationThreadPool.isShutdown();
+            atpRunning = executorService.isShutdown();
         } catch (Exception ignore) {
             // isShutdown() will thrown an exception in an EE7 environment
             // when using a ManagedExecutorService.
@@ -1179,7 +1179,7 @@ public Builder(AsyncHttpClientConfig prototype) {
             userAgent = prototype.getUserAgent();
             followRedirect = prototype.isFollowRedirect();
             compressionEnforced = prototype.isCompressionEnforced();
-            applicationThreadPool = prototype.executorService();
+            applicationThreadPool = prototype.getExecutorService();
 
             requestFilters.clear();
             responseFilters.clear();

api/src/main/java/org/asynchttpclient/config/AsyncHttpClientConfigBean.java

@@ -80,7 +80,7 @@ void configureDefaults() {
     }
 
     void configureExecutors() {
-        applicationThreadPool = Executors.newCachedThreadPool(new ThreadFactory() {
+        executorService = Executors.newCachedThreadPool(new ThreadFactory() {
             public Thread newThread(Runnable r) {
                 Thread t = new Thread(r, "AsyncHttpClient-Callback");
                 t.setDaemon(true);
@@ -160,10 +160,10 @@ public AsyncHttpClientConfigBean setAllowPoolingConnections(boolean allowPooling
     }
 
     public AsyncHttpClientConfigBean setApplicationThreadPool(ExecutorService applicationThreadPool) {
-        if (this.applicationThreadPool != null) {
-            this.applicationThreadPool.shutdownNow();
+        if (this.executorService != null) {
+            this.executorService.shutdownNow();
         }
-        this.applicationThreadPool = applicationThreadPool;
+        this.executorService = applicationThreadPool;
         return this;
     }
 

providers/netty3/src/main/java/org/asynchttpclient/netty/NettyAsyncHttpProvider.java

@@ -70,7 +70,7 @@ public void close() {
                 channelManager.close();
 
                 // FIXME shouldn't close if not allowed
-                config.executorService().shutdown();
+                config.getExecutorService().shutdown();
 
                 if (allowStopNettyTimer)
                     nettyTimer.stop();

providers/netty3/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java

@@ -195,7 +195,7 @@ public Semaphore apply(Object partitionKey) {
             int numWorkers = config.getIoThreadMultiplier() * Runtime.getRuntime().availableProcessors();
             LOGGER.trace("Number of application's worker threads is {}", numWorkers);
             NioClientBossPool nioClientBossPool = new NioClientBossPool(e, 1, new HashedWheelTimer(), ThreadNameDeterminer.CURRENT);
-            NioWorkerPool nioWorkerPool = new NioWorkerPool(config.executorService(), numWorkers, ThreadNameDeterminer.CURRENT);
+            NioWorkerPool nioWorkerPool = new NioWorkerPool(config.getExecutorService(), numWorkers, ThreadNameDeterminer.CURRENT);
             socketChannelFactory = new NioClientSocketChannelFactory(nioClientBossPool, nioWorkerPool);
             allowReleaseSocketChannelFactory = true;
         }
@@ -330,7 +330,7 @@ public void close() {
         }
 
         // FIXME also shutdown in provider
-        config.executorService().shutdown();
+        config.getExecutorService().shutdown();
         if (allowReleaseSocketChannelFactory) {
             socketChannelFactory.releaseExternalResources();
             httpBootstrap.releaseExternalResources();