Skip to content

Commit fef6970

Browse files
committed
Merge pull request bestiejs#30 miketaylr/issue-27
Also fixes issues with bestiejs#28
2 parents fb60a6e + 4599f65 commit fef6970

File tree

2 files changed

+22
-18
lines changed

2 files changed

+22
-18
lines changed

platform.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -555,6 +555,10 @@
555555
if (/\bSimulator\b/i.test(ua)) {
556556
product = (product ? product + ' ' : '') + 'Simulator';
557557
}
558+
// detect Firefox OS
559+
if ((/\(Mobile|Tablet.*Firefox/i).test(ua)) {
560+
os = 'Firefox OS';
561+
}
558562
// detect iOS
559563
if (/^iP/.test(product)) {
560564
name || (name = 'Safari');
@@ -676,8 +680,8 @@
676680
version = version.replace(RegExp(data + '\\+?$'), '') +
677681
(prerelease == 'beta' ? beta : alpha) + (/\d+\+?/.exec(data) || '');
678682
}
679-
// rename code name "Fennec"
680-
if (name == 'Fennec') {
683+
// detect Firefox Mobile
684+
if (name == 'Fennec' || name == 'Firefox' && /Android|Firefox OS/.test(os)) {
681685
name = 'Firefox Mobile';
682686
}
683687
// obscure Maxthon's unreliable version

test/test.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -617,6 +617,22 @@
617617
'version': '24.0'
618618
},
619619

620+
'Firefox Mobile#{ }24.0 on Android': {
621+
'ua': 'Mozilla/5.0 (Android; Tablet; rv:24.0) Gecko/24.0 Firefox/24.0',
622+
'layout': 'Gecko',
623+
'name': 'Firefox Mobile',
624+
'os': 'Android',
625+
'version': '24.0'
626+
},
627+
628+
'Firefox Mobile 26.0 on Firefox OS': {
629+
'ua': 'Mozilla/5.0 (Tablet; rv:26.0) Gecko/26.0 Firefox/26.0',
630+
'layout': 'Gecko',
631+
'name': 'Firefox Mobile',
632+
'os': 'Firefox OS',
633+
'version': '26.0'
634+
},
635+
620636
'Firefox Mobile 2.0#{beta}1 on Android': {
621637
'ua': 'Mozilla/5.0 (Android; Linux armv7l; rv:2.0b6pre) Gecko/20100907 Firefox/4.0b6pre Fennec/2.0b1pre',
622638
'layout': 'Gecko',
@@ -642,22 +658,6 @@
642658
'version': '10.0.5'
643659
},
644660

645-
'Firefox Mobile 24.0 on Android': {
646-
'ua': 'Mozilla/5.0 (Android; Mobile; rv:24.0) Gecko/24.0 Firefox/24.0',
647-
'layout': 'Gecko',
648-
'name': 'Firefox Mobile',
649-
'os': 'Android',
650-
'version': '24.0'
651-
},
652-
653-
'Firefox Mobile 24.0 on Android': {
654-
'ua': 'Mozilla/5.0 (Android; Tablet; rv:24.0) Gecko/24.0 Firefox/24.0',
655-
'layout': 'Gecko',
656-
'name': 'Firefox Mobile',
657-
'os': 'Android',
658-
'version': '24.0'
659-
},
660-
661661
'Flock 2.0#{alpha}1 on Linux i686': {
662662
'ua': 'Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008051917 Firefox/3.0pre Flock/2.0a1pre',
663663
'layout': 'Gecko',

0 commit comments

Comments
 (0)