Drop Proxy-Connection header, close AsyncHttpClient#404

Author: Stephane Landelle

api/src/test/java/org/asynchttpclient/async/AsyncProvidersBasicTest.java

@@ -741,7 +741,7 @@ public void onThrowable(Throwable t) {
             }).get();
 
             assertEquals(response.getStatusCode(), 200);
-            assertEquals(response.getHeader("X-Proxy-Connection"), "keep-alive");
+            assertEquals(response.getHeader("X-Connection"), "keep-alive");
         } finally {
             client.close();
         }

api/src/test/java/org/asynchttpclient/async/ProxyTunnellingTest.java

@@ -95,7 +95,7 @@ public Response onCompleted(Response response) throws Exception {
             });
             Response r = responseFuture.get();
             assertEquals(r.getStatusCode(), 200);
-            assertEquals(r.getHeader("X-Proxy-Connection"), "keep-alive");
+            assertEquals(r.getHeader("X-Connection"), "keep-alive");
         } finally {
             asyncHttpClient.close();
         }
@@ -123,7 +123,7 @@ public Response onCompleted(Response response) throws Exception {
             });
             Response r = responseFuture.get();
             assertEquals(r.getStatusCode(), 200);
-            assertEquals(r.getHeader("X-Proxy-Connection"), "keep-alive");
+            assertEquals(r.getHeader("X-Connection"), "keep-alive");
         } finally {
             asyncHttpClient.close();
         }
@@ -141,7 +141,7 @@ public void testSimpleAHCConfigProxy() throws IOException, InterruptedException,
             Response r = client.get().get();
 
             assertEquals(r.getStatusCode(), 200);
-            assertEquals(r.getHeader("X-Proxy-Connection"), "keep-alive");
+            assertEquals(r.getHeader("X-Connection"), "keep-alive");
         } finally {
             client.close();
         }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyRequests.java

@@ -317,11 +317,6 @@ public static NettyRequest newNettyRequest(AsyncHttpClientConfig config, Request
             httpRequest.headers().set(HttpHeaders.Names.CONNECTION, AsyncHttpProviderUtils.keepAliveHeaderValue(config));
         }
 
-        // FIXME Wikipedia says that Proxy-Connection was a misunderstanding of Connection http://en.wikipedia.org/wiki/List_of_HTTP_header_fields
-        if (!httpRequest.headers().contains("Proxy-Connection")) {
-            httpRequest.headers().set("Proxy-Connection", AsyncHttpProviderUtils.keepAliveHeaderValue(config));
-        }
-
         final Realm realm = request.getRealm() != null ? request.getRealm() : config.getRealm();
 
         String hostHeader = hostHeader(request, uri, realm);