File tree Expand file tree Collapse file tree 3 files changed +21
-8
lines changed Expand file tree Collapse file tree 3 files changed +21
-8
lines changed Original file line number Diff line number Diff line change 1
1
2
2
# Changelog
3
3
4
+ ## Version 1.0.8
5
+
6
+ - Fix Firefox-compatibility issue in Gmail click-jack prevention.
7
+
4
8
## Version 1.0.7
5
9
6
10
- Fix issues with Gmail preventing click-events on buttons registered
Original file line number Diff line number Diff line change 1
1
{
2
2
"name" : " gmail-js" ,
3
- "version" : " 1.0.7 " ,
3
+ "version" : " 1.0.8 " ,
4
4
"description" : " JavaScript API for Gmail (useful for chrome extensions)" ,
5
5
"main" : " src/gmail.js" ,
6
6
"types" : " src/gmail.d.ts" ,
Original file line number Diff line number Diff line change @@ -2436,18 +2436,27 @@ var Gmail = function(localJQuery) {
2436
2436
api . tracker . custom_dom_observers [ action ] = config ;
2437
2437
} ;
2438
2438
2439
+ var getTarget = function ( e ) {
2440
+ // firefox does not support e.path
2441
+ if ( e . path ) {
2442
+ return e . path [ 0 ] ;
2443
+ } else {
2444
+ return e . target ;
2445
+ }
2446
+ } ;
2439
2447
2448
+ // prevent gmail jacking our click-events!
2440
2449
var preventGmailJacking = function ( ) {
2441
- // prevent gmail jacking our click-events!
2442
-
2443
2450
// install event-handler only once!
2444
2451
if ( ! api . tracker . jackPreventionInstalled ) {
2445
2452
window . addEventListener ( "click" , ( e ) => {
2446
- const realTarget = e . path [ 0 ] ;
2447
- const gmailJsButton = realTarget . querySelector ( ".gmailjs" ) ;
2448
- if ( gmailJsButton ) {
2449
- gmailJsButton . click ( ) ;
2450
- e . preventDefault ( ) ;
2453
+ const target = getTarget ( e ) ;
2454
+ if ( target ) {
2455
+ const gmailJsButton = target . querySelector ( ".gmailjs" ) ;
2456
+ if ( gmailJsButton ) {
2457
+ gmailJsButton . click ( ) ;
2458
+ e . preventDefault ( ) ;
2459
+ }
2451
2460
}
2452
2461
} ) ;
2453
2462
api . tracker . jackPreventionInstalled = true ;
You can’t perform that action at this time.
0 commit comments