Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: LSK-React/react-components
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Khan/react-components
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 11, 2018

  1. Update tex to include load-mathjax rather than rely on global

    Summary: Please note that the linter complained about the order of a few methods so I had to move them around.
    
    Test Plan:
    Check out some fixtures that use tex.jsx such as
    `texified-code.jsx.fixture.js` and ensure everything renders properly.
    
    Reviewers: #webpack, john
    
    Reviewed By: #webpack, john
    
    Subscribers: john, kevinb, davidflanagan
    
    Differential Revision: https://phabricator.khanacademy.org/D49193
    Jesse Atkinson committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    9ed4999 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2018

  1. Fallback to MathJAX on any Katex error, not just parse errors

    Summary:
    Bugs CP-879 and CP-1742 are caused by a TypeError thrown by KaTeX.
    We already fall back to MathJAX rendering when KaTeX throws a parse
    error. But currently we rethrow other kinds of errors. This patch
    changes that so we fallback to MathJAX for any kind of KaTeX error.
    
    The underlying KaTeX error has been fixed upstream and will go away
    when we upgrade webapp to use KaTeX 1.0. Since we've got the MathJAX
    fallback, however, it seems worth using it in case other errors arise
    in the future.
    
    Test Plan:
    Visit the following URL with this patch and verifies that it renders:
    http://localhost:8081/math/k-8-grades/fr-v2-terminale-s/fr-v2-matrices-enseignement-de-spcialit/fr-v2-oprations-sur-les-matrices/a/multiplying-matrices-by-scalars?lang=fr
    
    Reviewers: kevinb, michaelpolyak
    
    Reviewed By: kevinb
    
    Subscribers: tom
    
    Differential Revision: https://phabricator.khanacademy.org/D50139
    David Flanagan committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    a9315ce View commit details
    Browse the repository at this point in the history
Loading