Skip to content

Commit 0cb0ee1

Browse files
author
Stephane Landelle
committed
Fix NPE when re-scheduling read timeouts, close AsyncHttpClient#773
1 parent 32023fa commit 0cb0ee1

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/main/java/com/ning/http/client/providers/netty/request/timeout/ReadTimeoutTimerTask.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,5 @@ public void run(Timeout timeout) throws Exception {
6767
// otherwise, no need to reschedule: requestTimeout will happen sooner
6868
timeoutsHolder.readTimeout = null;
6969
}
70-
71-
// this task should be evacuated from the timer but who knows
72-
nettyResponseFuture = null;
7370
}
7471
}

src/main/java/com/ning/http/client/providers/netty/request/timeout/RequestTimeoutTimerTask.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,5 @@ public void run(Timeout timeout) throws Exception {
4646
String message = "Request timed out to " + remoteAddress + " of " + requestTimeout + " ms";
4747
long age = millisTime() - nettyResponseFuture.getStart();
4848
expire(message, age);
49-
50-
// this task should be evacuated from the timer but who knows
51-
nettyResponseFuture = null;
5249
}
5350
}

0 commit comments

Comments
 (0)