chore(typings): remove StringMap

This was a poorly typed attempt to mimic TypeScript's index signatures,
which we can use instead.
This eliminates a very strange type that we were exposing to users, but
not re-exporting through our public API.

Fixes angular#4483

Author: alexeagle

docs/typescript-definition-package/templates/angular2/angular2.d.ts.template.html

@@ -2,7 +2,6 @@
 {% block staticDeclarations %}
 
 interface Map<K,V> {}
-interface StringMap<K,V> extends Map<K,V> {}
 
 {% for alias, module in doc.moduleDocs %}
 declare module {$ module.namespace $} {

modules/angular2/manual_typings/globals.d.ts

@@ -5,10 +5,6 @@
 /// <reference path="../typings/zone/zone.d.ts"/>
 declare var assert: any;
 
-// FIXME: K must be string!
-// FIXME: should have an index signature, `[k: string]: V;`
-interface StringMap<K extends string, V> {}
-
 interface BrowserNodeGlobal {
   Object: typeof Object;
   Array: typeof Array;

modules/angular2/src/animate/animation.ts

@@ -96,7 +96,7 @@ export class Animation {
    * Applies the provided styles to the element
    * @param styles
    */
-  applyStyles(styles: StringMap<string, any>): void {
+  applyStyles(styles: {[key: string]: any}): void {
     StringMapWrapper.forEach(styles, (value, key) => {
       var dashCaseKey = camelCaseToDashCase(key);
       if (isPresent(DOM.getStyle(this.element, dashCaseKey))) {

modules/angular2/src/animate/css_animation_builder.ts

@@ -61,15 +61,15 @@ export class CssAnimationBuilder {
    * @param from
    * @param to
    */
-  setStyles(from: StringMap<string, any>, to: StringMap<string, any>): CssAnimationBuilder {
+  setStyles(from: {[key: string]: any}, to: {[key: string]: any}): CssAnimationBuilder {
     return this.setFromStyles(from).setToStyles(to);
   }
 
   /**
    * Sets the initial styles for the animation
    * @param from
    */
-  setFromStyles(from: StringMap<string, any>): CssAnimationBuilder {
+  setFromStyles(from: {[key: string]: any}): CssAnimationBuilder {
     this.data.fromStyles = from;
     return this;
   }
@@ -78,7 +78,7 @@ export class CssAnimationBuilder {
    * Sets the destination styles for the animation
    * @param to
    */
-  setToStyles(to: StringMap<string, any>): CssAnimationBuilder {
+  setToStyles(to: {[key: string]: any}): CssAnimationBuilder {
     this.data.toStyles = to;
     return this;
   }

modules/angular2/src/animate/css_animation_options.ts

@@ -1,9 +1,9 @@
 export class CssAnimationOptions {
   /** initial styles for the element */
-  fromStyles: StringMap<string, any>;
+  fromStyles: {[key: string]: any};
 
   /** destination styles for the element */
-  toStyles: StringMap<string, any>;
+  toStyles: {[key: string]: any};
 
   /** classes to be added to the element */
   classesToAdd: string[] = [];

modules/angular2/src/core/change_detection/abstract_change_detector.ts

@@ -278,7 +278,7 @@ export class AbstractChangeDetector<T> implements ChangeDetector {
     this.dispatcher.logBindingUpdate(this._currentBinding(), value);
   }
 
-  addChange(changes: StringMap<string, any>, oldValue: any, newValue: any): StringMap<string, any> {
+  addChange(changes: {[key: string]: any}, oldValue: any, newValue: any): {[key: string]: any} {
     if (isBlank(changes)) {
       changes = {};
     }

modules/angular2/src/core/change_detection/change_detection_util.ts

@@ -124,7 +124,7 @@ export class ChangeDetectionUtil {
   static cond(cond, trueVal, falseVal): any { return cond ? trueVal : falseVal; }
 
   static mapFn(keys: any[]): any {
-    function buildMap(values): StringMap<any, any> {
+    function buildMap(values): {[k: /*any*/ string]: any} {
       var res = StringMapWrapper.create();
       for (var i = 0; i < keys.length; ++i) {
         StringMapWrapper.set(res, keys[i], values[i]);

modules/angular2/src/core/compiler/directive_metadata.ts

@@ -34,12 +34,12 @@ export class CompileTypeMetadata {
     this.isHost = normalizeBool(isHost);
   }
 
-  static fromJson(data: StringMap<string, any>): CompileTypeMetadata {
+  static fromJson(data: {[key: string]: any}): CompileTypeMetadata {
     return new CompileTypeMetadata(
         {name: data['name'], moduleUrl: data['moduleUrl'], isHost: data['isHost']});
   }
 
-  toJson(): StringMap<string, any> {
+  toJson(): {[key: string]: any} {
     return {
       // Note: Runtime type can't be serialized...
       'name': this.name,
@@ -72,7 +72,7 @@ export class CompileTemplateMetadata {
     this.ngContentSelectors = isPresent(ngContentSelectors) ? ngContentSelectors : [];
   }
 
-  static fromJson(data: StringMap<string, any>): CompileTemplateMetadata {
+  static fromJson(data: {[key: string]: any}): CompileTemplateMetadata {
     return new CompileTemplateMetadata({
       encapsulation: isPresent(data['encapsulation']) ?
                          VIEW_ENCAPSULATION_VALUES[data['encapsulation']] :
@@ -85,7 +85,7 @@ export class CompileTemplateMetadata {
     });
   }
 
-  toJson(): StringMap<string, any> {
+  toJson(): {[key: string]: any} {
     return {
       'encapsulation':
           isPresent(this.encapsulation) ? serializeEnum(this.encapsulation) : this.encapsulation,
@@ -109,7 +109,7 @@ export class CompileDirectiveMetadata {
     changeDetection?: ChangeDetectionStrategy,
     inputs?: string[],
     outputs?: string[],
-    host?: StringMap<string, string>,
+    host?: {[key: string]: string},
     lifecycleHooks?: LifecycleHooks[],
     template?: CompileTemplateMetadata
   } = {}): CompileDirectiveMetadata {
@@ -169,11 +169,11 @@ export class CompileDirectiveMetadata {
   selector: string;
   exportAs: string;
   changeDetection: ChangeDetectionStrategy;
-  inputs: StringMap<string, string>;
-  outputs: StringMap<string, string>;
-  hostListeners: StringMap<string, string>;
-  hostProperties: StringMap<string, string>;
-  hostAttributes: StringMap<string, string>;
+  inputs: {[key: string]: string};
+  outputs: {[key: string]: string};
+  hostListeners: {[key: string]: string};
+  hostProperties: {[key: string]: string};
+  hostAttributes: {[key: string]: string};
   lifecycleHooks: LifecycleHooks[];
   template: CompileTemplateMetadata;
   constructor({type, isComponent, dynamicLoadable, selector, exportAs, changeDetection, inputs,
@@ -184,11 +184,11 @@ export class CompileDirectiveMetadata {
     selector?: string,
     exportAs?: string,
     changeDetection?: ChangeDetectionStrategy,
-    inputs?: StringMap<string, string>,
-    outputs?: StringMap<string, string>,
-    hostListeners?: StringMap<string, string>,
-    hostProperties?: StringMap<string, string>,
-    hostAttributes?: StringMap<string, string>,
+    inputs?: {[key: string]: string},
+    outputs?: {[key: string]: string},
+    hostListeners?: {[key: string]: string},
+    hostProperties?: {[key: string]: string},
+    hostAttributes?: {[key: string]: string},
     lifecycleHooks?: LifecycleHooks[],
     template?: CompileTemplateMetadata
   } = {}) {
@@ -207,7 +207,7 @@ export class CompileDirectiveMetadata {
     this.template = template;
   }
 
-  static fromJson(data: StringMap<string, any>): CompileDirectiveMetadata {
+  static fromJson(data: {[key: string]: any}): CompileDirectiveMetadata {
     return new CompileDirectiveMetadata({
       isComponent: data['isComponent'],
       dynamicLoadable: data['dynamicLoadable'],
@@ -229,7 +229,7 @@ export class CompileDirectiveMetadata {
     });
   }
 
-  toJson(): StringMap<string, any> {
+  toJson(): {[key: string]: any} {
     return {
       'isComponent': this.isComponent,
       'dynamicLoadable': this.dynamicLoadable,

modules/angular2/src/core/compiler/template_parser.ts

@@ -436,8 +436,8 @@ class TemplateParseVisitor implements HtmlAstVisitor {
     return directiveAsts;
   }
 
-  private _createDirectiveHostPropertyAsts(elementName: string,
-                                           hostProps: StringMap<string, string>, sourceInfo: string,
+  private _createDirectiveHostPropertyAsts(elementName: string, hostProps: {[key: string]: string},
+                                           sourceInfo: string,
                                            targetPropertyAsts: BoundElementPropertyAst[]) {
     if (isPresent(hostProps)) {
       StringMapWrapper.forEach(hostProps, (expression, propName) => {
@@ -448,16 +448,16 @@ class TemplateParseVisitor implements HtmlAstVisitor {
     }
   }
 
-  private _createDirectiveHostEventAsts(hostListeners: StringMap<string, string>,
-                                        sourceInfo: string, targetEventAsts: BoundEventAst[]) {
+  private _createDirectiveHostEventAsts(hostListeners: {[key: string]: string}, sourceInfo: string,
+                                        targetEventAsts: BoundEventAst[]) {
     if (isPresent(hostListeners)) {
       StringMapWrapper.forEach(hostListeners, (expression, propName) => {
         this._parseEvent(propName, expression, sourceInfo, [], targetEventAsts);
       });
     }
   }
 
-  private _createDirectivePropertyAsts(directiveProperties: StringMap<string, string>,
+  private _createDirectivePropertyAsts(directiveProperties: {[key: string]: string},
                                        boundProps: BoundElementOrDirectiveProperty[],
                                        targetBoundDirectiveProps: BoundDirectivePropertyAst[]) {
     if (isPresent(directiveProperties)) {

modules/angular2/src/core/dom/dom_adapter.ts

@@ -27,7 +27,7 @@ export abstract class DomAdapter {
    * Maps attribute names to their corresponding property names for cases
    * where attribute name doesn't match property name.
    */
-  attrToPropMap: StringMap<string, string>;
+  attrToPropMap: {[key: string]: string};
 
   abstract parse(templateHtml: string);
   abstract query(selector: string): any;