DevOps task formal PR #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial test of GitHub actions
changed ti install, test
trying with cd command
attempt with npm ci and actions/setup-node@v3
attempt with "working-directory" parameters running: - npm run start - npm run test
fixed git fail
…conf file being copied inside the container
Changed dockerfile to give nginx user privileges and deleted user mode from nginx.conf
kseniyashaydurova
requested changes
Oct 28, 2024
Collaborator
kseniyashaydurova
left a comment
kseniyashaydurova
left a comment
There was a problem hiding this comment.
Needs a bit more changes
dmitry-mightydevops
approved these changes
Oct 29, 2024
Co-authored-by: Dmitry Semenov <[email protected]>
Co-authored-by: Dmitry Semenov <[email protected]>
kseniyashaydurova
requested review from
kseniyashaydurova
and removed request for
kseniyashaydurova
kseniyashaydurova
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DevOps task formal PR for the code review
The project consists of: