Transactions - adding willRenderTimeline to handle tricky cases

Summary: Fixes T6693.

Test Plan:
Made a bunch of comments on a diff with differential, being sure to leave inlines here and there. This reproduced the issue in T6693. With this patch this issue no longer reproduces!

Successfully "showed older changes" in Maniphest too.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6693

Differential Revision: https://secure.phabricator.com/D10931

Author: bobtrahan

resources/celerity/map.php

@@ -421,7 +421,7 @@
     'rsrc/js/application/repository/repository-crossreference.js' => 'f9539603',
     'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
     'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => 'd6f54db0',
-    'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'c30ccda9',
+    'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '83458cbb',
     'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '9f7309fb',
     'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea',
     'rsrc/js/application/uiexample/JavelinViewExample.js' => 'd4a14807',
@@ -625,7 +625,7 @@
     'javelin-behavior-phabricator-reveal-content' => '60821bc7',
     'javelin-behavior-phabricator-search-typeahead' => '724b1247',
     'javelin-behavior-phabricator-show-all-transactions' => '7c273581',
-    'javelin-behavior-phabricator-show-older-transactions' => 'c30ccda9',
+    'javelin-behavior-phabricator-show-older-transactions' => '83458cbb',
     'javelin-behavior-phabricator-tooltips' => '3ee3408b',
     'javelin-behavior-phabricator-transaction-comment-form' => '9f7309fb',
     'javelin-behavior-phabricator-transaction-list' => '13c739ea',
@@ -1375,6 +1375,12 @@
     '82ce2142' => array(
       'aphront-typeahead-control-css',
     ),
+    '83458cbb' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-dom',
+      'phabricator-busy',
+    ),
     '84845b5b' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1668,12 +1674,6 @@
       'javelin-util',
       'phabricator-shaped-request',
     ),
-    'c30ccda9' => array(
-      'javelin-behavior',
-      'javelin-stratcom',
-      'javelin-dom',
-      'phabricator-busy',
-    ),
     'c4569c05' => array(
       'javelin-magical-init',
       'javelin-install',

src/applications/almanac/storage/AlmanacBinding.php

@@ -184,4 +184,11 @@ public function getApplicationTransactionTemplate() {
     return new AlmanacBindingTransaction();
   }
 
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
 }

src/applications/almanac/storage/AlmanacDevice.php

@@ -162,6 +162,13 @@ public function getApplicationTransactionTemplate() {
     return new AlmanacDeviceTransaction();
   }
 
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
 
 /* -(  PhabricatorSSHPublicKeyInterface  )----------------------------------- */
 

src/applications/almanac/storage/AlmanacNetwork.php

@@ -59,6 +59,13 @@ public function getApplicationTransactionTemplate() {
     return new AlmanacNetworkTransaction();
   }
 
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
 
 /* -(  PhabricatorPolicyInterface  )----------------------------------------- */
 

src/applications/almanac/storage/AlmanacService.php

@@ -161,4 +161,11 @@ public function getApplicationTransactionTemplate() {
     return new AlmanacServiceTransaction();
   }
 
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
 }

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

@@ -97,6 +97,13 @@ public function getApplicationTransactionTemplate() {
     return new PhabricatorAuthProviderConfigTransaction();
   }
 
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
 
 /* -(  PhabricatorPolicyInterface  )----------------------------------------- */
 

src/applications/base/controller/PhabricatorController.php

@@ -529,7 +529,8 @@ public function newDialog() {
   protected function buildTransactionTimeline(
     PhabricatorApplicationTransactionInterface $object,
     PhabricatorApplicationTransactionQuery $query,
-    PhabricatorMarkupEngine $engine = null) {
+    PhabricatorMarkupEngine $engine = null,
+    $render_data = array()) {
 
     $viewer = $this->getRequest()->getUser();
     $xaction = $object->getApplicationTransactionTemplate();
@@ -564,7 +565,9 @@ protected function buildTransactionTimeline(
       ->setUser($viewer)
       ->setObjectPHID($object->getPHID())
       ->setTransactions($xactions)
-      ->setPager($pager);
+      ->setPager($pager)
+      ->setRenderData($render_data);
+    $object->willRenderTimeline($timeline, $this->getRequest());
 
     return $timeline;
   }

src/applications/config/storage/PhabricatorConfigEntry.php

@@ -68,6 +68,13 @@ public function getApplicationTransactionTemplate() {
     return new PhabricatorConfigTransaction();
   }
 
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
 
 /* -(  PhabricatorPolicyInterface  )----------------------------------------- */
 

src/applications/dashboard/storage/PhabricatorDashboard.php

@@ -99,6 +99,13 @@ public function getApplicationTransactionTemplate() {
     return new PhabricatorDashboardTransaction();
   }
 
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
 
 /* -(  PhabricatorPolicyInterface  )----------------------------------------- */
 

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

@@ -105,6 +105,13 @@ public function getApplicationTransactionTemplate() {
     return new PhabricatorDashboardPanelTransaction();
   }
 
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
 
 /* -(  PhabricatorPolicyInterface  )----------------------------------------- */