Transactions - make sure to do fancy remarkup stuff on edit too

Summary: Fixes T6648. We do some automagical hotness based on the text you enter in remarkup textareas - e.g. adding projects or mentioning other objects. Refine the code here so that even when just editing a comment we build these transactions and apply them.

Test Plan: edited a comment and noted new mentions and projects showed up appropriately...!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6648

Differential Revision: https://secure.phabricator.com/D10922

Author: bobtrahan

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

@@ -69,7 +69,26 @@ public function applyEdit(
         $xaction->setViewPolicy($comment->getViewPolicy());
         $xaction->setEditPolicy($comment->getEditPolicy());
         $xaction->save();
-
+        $xaction->attachComment($comment);
+
+        $object = id(new PhabricatorObjectQuery())
+          ->withPHIDs(array($xaction->getObjectPHID()))
+          ->setViewer($this->getActor())
+          ->executeOne();
+        if ($object &&
+            $object instanceof PhabricatorApplicationTransactionInterface) {
+          $editor = $object->getApplicationTransactionEditor();
+          $editor->setActor($this->getActor());
+          $support_xactions = $editor->getExpandedSupportTransactions(
+            $object,
+            $xaction);
+          if ($support_xactions) {
+            $editor
+              ->setContentSource($this->getContentSource())
+              ->setContinueOnNoEffect(true)
+              ->applyTransactions($object, $support_xactions);
+          }
+        }
       $xaction->endReadLocking();
     $xaction->saveTransaction();
 
@@ -85,8 +104,6 @@ public function applyEdit(
       $editor->save();
     }
 
-    $xaction->attachComment($comment);
-
     return $this;
   }
 

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -1117,6 +1117,29 @@ protected function expandTransaction(
   }
 
 
+  public function getExpandedSupportTransactions(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    $xactions = array($xaction);
+    $xactions = $this->expandSupportTransactions(
+      $object,
+      $xactions);
+
+    if (count($xactions) == 1) {
+      return array();
+    }
+
+    foreach ($xactions as $index => $cxaction) {
+      if ($cxaction === $xaction) {
+        unset($xactions[$index]);
+        break;
+      }
+    }
+
+    return $xactions;
+  }
+
   private function expandSupportTransactions(
     PhabricatorLiskDAO $object,
     array $xactions) {