remove unusefull code and optimized code

Author: M-blockcoder

chainbase/src/main/java/org/tron/common/utils/Commons.java

@@ -19,7 +19,6 @@
 @Slf4j(topic = "Commons")
 public class Commons {
 
-  public static final int ADDRESS_SIZE = 42;
   public static final int ASSET_ISSUE_COUNT_LIMIT_MAX = 1000;
 
   public static byte[] clone(byte[] value) {

chainbase/src/main/java/org/tron/common/utils/Hash.java

@@ -2,6 +2,7 @@
 
 import lombok.extern.slf4j.Slf4j;
 import org.tron.common.utils.ByteArray;
+import org.tron.common.utils.ByteUtil;
 import org.tron.common.utils.DBConfig;
 import org.tron.common.zksnark.LibrustzcashParam.BindingSigParams;
 import org.tron.common.zksnark.LibrustzcashParam.CheckOutputParams;
@@ -95,7 +96,7 @@ public static boolean librustzcashComputeNf(ComputeNfParams params) {
    */
   public static byte[] librustzcashAskToAk(byte[] ask) throws ZksnarkException {
     if (!isOpenZen()) {
-      return ByteArray.EMPTY_BYTE_ARRAY;
+      return ByteUtil.EMPTY_BYTE_ARRAY;
     }
     LibrustzcashParam.valid32Params(ask);
     byte[] ak = new byte[32];
@@ -109,7 +110,7 @@ public static byte[] librustzcashAskToAk(byte[] ask) throws ZksnarkException {
    */
   public static byte[] librustzcashNskToNk(byte[] nsk) throws ZksnarkException {
     if (!isOpenZen()) {
-      return ByteArray.EMPTY_BYTE_ARRAY;
+      return ByteUtil.EMPTY_BYTE_ARRAY;
     }
     LibrustzcashParam.valid32Params(nsk);
     byte[] nk = new byte[32];
@@ -124,7 +125,7 @@ public static byte[] librustzcashNskToNk(byte[] nsk) throws ZksnarkException {
    */
   public static byte[] librustzcashSaplingGenerateR(byte[] r) throws ZksnarkException {
     if (!isOpenZen()) {
-      return ByteArray.EMPTY_BYTE_ARRAY;
+      return ByteUtil.EMPTY_BYTE_ARRAY;
     }
     LibrustzcashParam.valid32Params(r);
     INSTANCE.librustzcashSaplingGenerateR(r);

chainbase/src/main/java/org/tron/common/zksnark/JLibrustzcash.java

@@ -106,10 +106,6 @@ public static byte[] decode(String input) throws IllegalArgumentException {
     return copyOfRange(temp, j - zeroCount, temp.length);
   }
 
-  public static BigInteger decodeToBigInteger(String input) throws IllegalArgumentException {
-    return new BigInteger(1, decode(input));
-  }
-
   //
   // number -> number / 58, returns number % 58
   //

common/src/main/java/org/tron/common/utils/Base58.java

@@ -1,5 +1,7 @@
 package org.tron.common.utils;
 
+import static org.tron.common.utils.ByteUtil.EMPTY_BYTE_ARRAY;
+
 import com.google.common.primitives.Ints;
 import com.google.common.primitives.Longs;
 import java.io.ByteArrayOutputStream;
@@ -33,8 +35,6 @@
 @Slf4j(topic = "utils")
 public class ByteArray {
 
-  public static final byte[] EMPTY_BYTE_ARRAY = new byte[0];
-
   public static String toHexString(byte[] data) {
     return data == null ? "" : Hex.toHexString(data);
   }

common/src/main/java/org/tron/common/utils/ByteArray.java

@@ -11,22 +11,6 @@
 
 public class CollectionUtils {
 
-  public static <K, V> List<V> collectList(Collection<K> items, Function<K, V> collector) {
-    List<V> collected = new ArrayList<>(items.size());
-    for (K item : items) {
-      collected.add(collector.apply(item));
-    }
-    return collected;
-  }
-
-  public static <K, V> Set<V> collectSet(Collection<K> items, Function<K, V> collector) {
-    Set<V> collected = new HashSet<>();
-    for (K item : items) {
-      collected.add(collector.apply(item));
-    }
-    return collected;
-  }
-
   public static <T> List<T> truncate(List<T> items, int limit) {
     if (limit > items.size()) {
       return new ArrayList<>(items);
@@ -65,24 +49,4 @@ public static <T> List<T> truncateRandom(List<T> items, int limit, int confirm)
     }
     return truncated;
   }
-
-  public static <T> List<T> selectList(Collection<T> items, Predicate<T> predicate) {
-    List<T> selected = new ArrayList<>();
-    for (T item : items) {
-      if (predicate.test(item)) {
-        selected.add(item);
-      }
-    }
-    return selected;
-  }
-
-  public static <T> Set<T> selectSet(Collection<T> items, Predicate<T> predicate) {
-    Set<T> selected = new HashSet<>();
-    for (T item : items) {
-      if (predicate.test(item)) {
-        selected.add(item);
-      }
-    }
-    return selected;
-  }
 }

common/src/main/java/org/tron/common/utils/CollectionUtils.java

@@ -18,7 +18,6 @@
 
 package org.tron.common.utils;
 
-import static java.util.Arrays.copyOfRange;
 import static org.tron.common.utils.ByteUtil.EMPTY_BYTE_ARRAY;
 import static org.tron.common.utils.ByteUtil.isNullOrZeroArray;
 import static org.tron.common.utils.ByteUtil.isSingleZero;