fix(typings): repair broken type-checking for StringMap

Note that the previous type of StringMap was overly permissive and didn't catch errors.
Also we have to explicitly type empty objects, which is explained here:
microsoft/TypeScript#5089

Closes angular#4487

Author: alexeagle

modules/angular2/src/core/compiler/directive_metadata.ts

@@ -113,9 +113,9 @@ export class CompileDirectiveMetadata {
     lifecycleHooks?: LifecycleHooks[],
     template?: CompileTemplateMetadata
   } = {}): CompileDirectiveMetadata {
-    var hostListeners = {};
-    var hostProperties = {};
-    var hostAttributes = {};
+    var hostListeners: {[key: string]: string} = {};
+    var hostProperties: {[key: string]: string} = {};
+    var hostAttributes: {[key: string]: string} = {};
     if (isPresent(host)) {
       StringMapWrapper.forEach(host, (value: string, key: string) => {
         var matches = RegExpWrapper.firstMatch(HOST_REG_EXP, key);
@@ -128,7 +128,7 @@ export class CompileDirectiveMetadata {
         }
       });
     }
-    var inputsMap = {};
+    var inputsMap: {[key: string]: string} = {};
     if (isPresent(inputs)) {
       inputs.forEach((bindConfig: string) => {
         // canonical syntax: `dirProp: elProp`
@@ -137,7 +137,7 @@ export class CompileDirectiveMetadata {
         inputsMap[parts[0]] = parts[1];
       });
     }
-    var outputsMap = {};
+    var outputsMap: {[key: string]: string} = {};
     if (isPresent(outputs)) {
       outputs.forEach((bindConfig: string) => {
         // canonical syntax: `dirProp: elProp`

modules/angular2/src/core/dom/generic_browser_adapter.ts

@@ -23,7 +23,7 @@ export abstract class GenericBrowserDomAdapter extends DomAdapter {
           }
         }
       }
-      var transEndEventNames = {
+      var transEndEventNames: {[key: string]: string} = {
         WebkitTransition: 'webkitTransitionEnd',
         MozTransition: 'transitionend',
         OTransition: 'oTransitionEnd otransitionend',

modules/angular2/src/core/dom/parse5_adapter.ts

@@ -17,7 +17,7 @@ import {
 import {BaseException, WrappedException} from 'angular2/src/core/facade/exceptions';
 import {SelectorMatcher, CssSelector} from 'angular2/src/core/compiler/selector';
 
-var _attrToPropMap = {
+var _attrToPropMap: {[key: string]: string} = {
   'class': 'className',
   'innerHtml': 'innerHTML',
   'readonly': 'readOnly',

modules/angular2/src/core/facade/collection.ts

@@ -86,7 +86,7 @@ export class MapWrapper {
     return result;
   }
   static toStringMap<T>(m: Map<string, T>): {[key: string]: T} {
-    var r = {};
+    var r: {[key: string]: T} = {};
     m.forEach((v, k) => r[k] = v);
     return r;
   }
@@ -135,7 +135,7 @@ export class StringMapWrapper {
   }
 
   static merge<V>(m1: {[key: string]: V}, m2: {[key: string]: V}): {[key: string]: V} {
-    var m = {};
+    var m: {[key: string]: V} = {};
 
     for (var attr in m1) {
       if (m1.hasOwnProperty(attr)) {

modules/angular2/src/core/forms/form_builder.ts

@@ -97,7 +97,7 @@ export class FormBuilder {
   }
 
   _reduceControls(controlsConfig: any): {[key: string]: modelModule.AbstractControl} {
-    var controls = {};
+    var controls: {[key: string]: modelModule.AbstractControl} = {};
     StringMapWrapper.forEach(controlsConfig, (controlConfig, controlName) => {
       controls[controlName] = this._createControl(controlConfig);
     });

modules/angular2/src/core/forms/validators.ts

@@ -29,14 +29,14 @@ export class Validators {
     return function(control: modelModule.Control) {
       var res = ListWrapper.reduce(validators, (res, validator) => {
         var errors = validator(control);
-        return isPresent(errors) ? StringMapWrapper.merge(res, errors) : res;
+        return isPresent(errors) ? StringMapWrapper.merge(<any>res, <any>errors) : res;
       }, {});
       return StringMapWrapper.isEmpty(res) ? null : res;
     };
   }
 
-  static group(group: modelModule.ControlGroup): {[key: string]: boolean} {
-    var res = {};
+  static group(group: modelModule.ControlGroup): {[key: string]: any[]} {
+    var res: {[key: string]: any[]} = {};
     StringMapWrapper.forEach(group.controls, (control, name) => {
       if (group.contains(name) && isPresent(control.errors)) {
         Validators._mergeErrors(control, res);
@@ -45,8 +45,8 @@ export class Validators {
     return StringMapWrapper.isEmpty(res) ? null : res;
   }
 
-  static array(array: modelModule.ControlArray): {[key: string]: boolean} {
-    var res = {};
+  static array(array: modelModule.ControlArray): {[key: string]: any[]} {
+    var res: {[key: string]: any[]} = {};
     array.controls.forEach((control) => {
       if (isPresent(control.errors)) {
         Validators._mergeErrors(control, res);

modules/angular2/src/core/linker/directive_resolver.ts

@@ -46,8 +46,8 @@ export class DirectiveResolver {
                                      propertyMetadata: {[key: string]: any[]}): DirectiveMetadata {
     var inputs = [];
     var outputs = [];
-    var host = {};
-    var queries = {};
+    var host: {[key: string]: string} = {};
+    var queries: {[key: string]: any} = {};
 
     StringMapWrapper.forEach(propertyMetadata, (metadata: any[], propName: string) => {
       metadata.forEach(a => {

modules/angular2/src/core/linker/proto_view_factory.ts

@@ -55,9 +55,9 @@ export class ProtoViewFactory {
     var result = this._cache.get(compiledTemplate.id);
     if (isBlank(result)) {
       var templateData = compiledTemplate.getData(this._appId);
-      result =
-          new AppProtoView(templateData.commands, ViewType.HOST, true,
-                           templateData.changeDetectorFactory, null, new ProtoPipes(new Map()));
+      var emptyMap: {[key: string]: PipeBinding} = {};
+      result = new AppProtoView(templateData.commands, ViewType.HOST, true,
+                                templateData.changeDetectorFactory, null, new ProtoPipes(emptyMap));
       this._cache.set(compiledTemplate.id, result);
     }
     return result;

modules/angular2/src/core/pipes/date_pipe.ts

@@ -81,7 +81,7 @@ var defaultLocale: string = 'en-US';
 @Pipe({name: 'date'})
 @Injectable()
 export class DatePipe implements PipeTransform {
-  static _ALIASES = {
+  static _ALIASES: {[key: string]: String} = {
     'medium': 'yMMMdjms',
     'short': 'yMdjm',
     'fullDate': 'yMMMMEEEEd',

modules/angular2/src/core/pipes/pipes.ts

@@ -14,7 +14,7 @@ import * as cd from 'angular2/src/core/change_detection/pipes';
 
 export class ProtoPipes {
   static fromBindings(bindings: PipeBinding[]): ProtoPipes {
-    var config = {};
+    var config: {[key: string]: PipeBinding} = {};
     bindings.forEach(b => config[b.name] = b);
     return new ProtoPipes(config);
   }