Skip to content
This repository was archived by the owner on May 18, 2021. It is now read-only.

Commit ffdc4b0

Browse files
Ismael Ramosiramos
authored andcommitted
feat(lazy images): replace ngx-progressive-image-loader for ng-lazyload-image
1 parent 8f8e993 commit ffdc4b0

File tree

13 files changed

+31
-62
lines changed

13 files changed

+31
-62
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
* Following the [best practices](https://angular.io/guide/styleguide)!
6666
* Search bar, to look for heroes
6767
* Custom loading page
68-
* Lazy loading images with [ngx-progressive-image-loader](https://github.com/maxisam/ngx-progressive-image-loader)
68+
* Lazy loading images with [ng-lazyload-image](https://github.com/tjoskar/ng-lazyload-image)
6969
* Modal and toasts (snakbar)!
7070
* Scroll restoration and anchor examples
7171
* Responsive layout (flex layout module)

angular.json

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@
2929
"input": "src/assets/images",
3030
"output": "/assets/images"
3131
},
32-
{
33-
"glob": "favicon.ico",
34-
"input": "src",
35-
"output": "/assets/common"
36-
},
3732
{
3833
"glob": "sitemap.xml",
3934
"input": "src/assets",
@@ -57,7 +52,6 @@
5752
],
5853
"styles": [
5954
"node_modules/@angular/material/prebuilt-themes/deeppurple-amber.css",
60-
"node_modules/ngx-progressive-image-loader/ngx-progressive-image-loader.scss",
6155
"src/assets/css/reset.css",
6256
"src/assets/css/loading.css",
6357
"src/app/shared/styles/global.scss"
@@ -205,11 +199,6 @@
205199
"input": "src/assets",
206200
"output": "/assets"
207201
},
208-
{
209-
"glob": "favicon.ico",
210-
"input": "src",
211-
"output": "/"
212-
},
213202
{
214203
"glob": "sitemap.xml",
215204
"input": "src/assets",

functions/package-lock.json

Lines changed: 8 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

functions/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@
4646
"helmet": "3.18.0",
4747
"moment": "2.24.0",
4848
"ng-animate": "0.3.4",
49+
"ng-lazyload-image": "5.1.2",
4950
"ngx-cookie": "4.1.2",
5051
"ngx-logger": "3.3.13",
51-
"ngx-progressive-image-loader": "4.0.0-beta.15",
5252
"ngx-window-token": "2.0.1",
5353
"reflect-metadata": "0.1.13",
5454
"rxjs": "6.5.2",

package-lock.json

Lines changed: 8 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@
6666
"grpc": "1.21.1",
6767
"helmet": "3.18.0",
6868
"ng-animate": "0.3.4",
69+
"ng-lazyload-image": "5.1.2",
6970
"ngx-cookie": "4.1.2",
7071
"ngx-logger": "3.3.13",
71-
"ngx-progressive-image-loader": "4.0.0-beta.15",
7272
"rxjs": "6.5.2",
7373
"tslib": "1.10.0",
7474
"zone.js": "0.9.1"

src/app/app.browser.module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ import {I18n} from '@ngx-translate/i18n-polyfill';
1212
import {HttpClientModule} from '@angular/common/http';
1313
import {registerLocaleData} from '@angular/common';
1414
import localeEs from '@angular/common/locales/es';
15-
import {NgxProgressiveImageLoaderModule} from 'ngx-progressive-image-loader';
1615
import {CookieModule} from 'ngx-cookie';
1716
import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
1817
import {TransferHttpCacheModule} from '@nguniversal/common';
1918
import {ROUTES_CONFIG, RoutesConfig} from './configs/routes.config';
2019
import {HomePageComponent} from './pages/home-page/home-page.component';
2120
import {Error404PageComponent} from './pages/error404-page/error404-page.component';
2221
import {ENDPOINTS_CONFIG, EndpointsConfig} from './configs/endpoints.config';
22+
import {LazyLoadImageModule} from 'ng-lazyload-image';
2323

2424
declare const require;
2525

@@ -38,7 +38,7 @@ registerLocaleData(localeEs, 'es');
3838
say: 'hello'
3939
}
4040
}),
41-
NgxProgressiveImageLoaderModule.forRoot(),
41+
LazyLoadImageModule.forRoot({}),
4242
CoreModule,
4343
SharedModule,
4444
AppRoutingModule

src/app/shared/components/hero-card/hero-card.component.html

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@
2121
</div>
2222
</mat-card-header>
2323
<a class="hero-detail-link" [routerLink]="hero.default ? [routesConfig.routes.heroes.detail(hero.id)] : []">
24-
<ngx-progressive-image-loader *ngIf="isBrowser"
25-
[filter]="'blur(3px) drop-shadow(0 0 0.75rem crimson)'"
26-
[placeholderImageSrc]="hero.avatarBlurredUrl">
27-
<img [src]="hero.avatarUrl" alt="avatar url" ngxProgressiveImage/>
28-
</ngx-progressive-image-loader>
24+
<img alt="{{hero.name}} hero image" [defaultImage]="hero.avatarBlurredUrl" [lazyLoad]="hero.avatarUrl">
2925
</a>
3026
</mat-card>

src/app/shared/components/hero-card/hero-card.component.spec.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {HeroCardComponent} from './hero-card.component';
33
import {Hero} from '../../../modules/heroes/shared/hero.model';
44
import {configureTestSuite} from 'ng-bullet';
5-
import {MockComponent} from 'ng-mocks';
65
import {MatCardModule} from '@angular/material/card';
76
import {MatIconModule} from '@angular/material/icon';
87
import {MatSnackBar} from '@angular/material/snack-bar';
@@ -13,7 +12,7 @@ import {RouterTestingModule} from '@angular/router/testing';
1312
import {ROUTES_CONFIG, RoutesConfig} from '../../../configs/routes.config';
1413
import {CookieService} from 'ngx-cookie';
1514
import {PLATFORM_ID} from '@angular/core';
16-
import {ProgressiveImageLoaderComponent} from 'ngx-progressive-image-loader';
15+
import {LazyLoadImageModule} from 'ng-lazyload-image';
1716

1817
describe('HeroCardComponent', () => {
1918
let component: HeroCardComponent;
@@ -27,10 +26,10 @@ describe('HeroCardComponent', () => {
2726
imports: [
2827
RouterTestingModule,
2928
MatCardModule,
30-
MatIconModule
29+
MatIconModule,
30+
LazyLoadImageModule
3131
],
3232
declarations: [
33-
MockComponent(ProgressiveImageLoaderComponent),
3433
HeroCardComponent
3534
],
3635
providers: [

src/app/shared/shared.module.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import {NgxExampleLibraryModule} from '@ismaestro/ngx-example-library';
1313
import {HeroLoadingComponent} from './components/hero-loading/hero-loading.component';
1414
import {NgxScrollToFirstInvalidModule} from '@ismaestro/ngx-scroll-to-first-invalid';
1515
import {LoadingPlaceholderComponent} from './components/loading-placeholder/loading-placeholder.component';
16-
import {NgxProgressiveImageLoaderModule} from 'ngx-progressive-image-loader';
1716
import {CapitalizeFirstPipe} from './pipes/capitalize-first.pipe';
17+
import {LazyLoadImageModule} from 'ng-lazyload-image';
1818

1919
@NgModule({
2020
imports: [
@@ -25,7 +25,7 @@ import {CapitalizeFirstPipe} from './pipes/capitalize-first.pipe';
2525
RouterModule,
2626
NgxExampleLibraryModule,
2727
NgxScrollToFirstInvalidModule,
28-
NgxProgressiveImageLoaderModule
28+
LazyLoadImageModule
2929
],
3030
declarations: [
3131
HeaderComponent,
@@ -50,8 +50,8 @@ import {CapitalizeFirstPipe} from './pipes/capitalize-first.pipe';
5050
HeroLoadingComponent,
5151
NgxScrollToFirstInvalidModule,
5252
LoadingPlaceholderComponent,
53-
NgxProgressiveImageLoaderModule,
54-
CapitalizeFirstPipe
53+
CapitalizeFirstPipe,
54+
LazyLoadImageModule
5555
]
5656
})
5757

0 commit comments

Comments
 (0)