forked from angular/angular
-
Notifications
You must be signed in to change notification settings - Fork 0
PQD #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
usernamealreadyis
wants to merge
758
commits into
Mariem-07:q-misko-master
Choose a base branch
from
juliemr:master
base: q-misko-master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PQD #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or production You can now run `gulp serve.e2e.prod` to instantiate a task that watches and compiles example and module files into the prod directory in dist and then allows the code to be run via protractor. Closes angular#2369
BREAKING CHANGE: This PR remove an ability to use pipes in the properties config. Instead, inject the pipe registry.
Document installation, command line usage, editors, etc.
Plugins may opt to return a DiffResult themselves, and avoid the need to calculate a diff Closes angular#2514
BREAKING CHANGE: compiler will throw on binding to non-existing properties. Till now it was possible to have a binding to a non-existing property, ex.: `<div [foo]="exp">`. From now on this is compilation error - any property binding needs to have at least one associated property: eaither on an HTML element or on any directive associated with a given element (directives' properites need to be declared using the `properties` field in the `@Directive` / `@Component` annotation). Closes angular#2598
…ading Also, simplify selectors. Closes angular#1706.
This makes it easy to mock browser location and paves the way to implementing hash routing.
BREAKING CHANGES: - host actions don't take an expression as value any more but only a method name, and assumes to get an array via the EventEmitter with the method arguments. - Renderer.setElementProperty does not take `style.`/... prefixes any more. Use the new methods `Renderer.setElementAttribute`, ... instead Part of angular#2476 Closes angular#2637
…/post-test tasks In order to speedup the startup time of test.unit.js task, we are moving the circular dependency check into a pre-test check that executes only on travis. Similarly we are moving the style check to a post-test check that executes on travis. This way if a circular dependency issue occurs, we find it before running tests on CI and if the code is not formatted we fail the build only if all the tests pass. Related to angular#2536 Related to angular#2094
This reverts commit d575915. See angular#2662
BREAKING CHANGES: - Almost all methods in `Renderer` now take a `RenderElementRef` instead of a `ViewRef` + `boundElementIndex`. - These methods can be called with the `ElementRef` from the app side directly. Closes angular#2706 Related to angular#2476
BREAKING CHANGES: - rename `ElementRef.domElement` to `ElementRef.nativeElement` - add `Renderer.getNativeElementSync` to make the app side less dependent on the dom renderer. - don’t use `ElementRef.nativeElement` in directives but use the methods on `Renderer` directly. - Removed `ElementRef.setAttribute`. Use `Renderer.setElementAttribute` instead. Closes angular#2712 Last part of angular#2476 Closes angular#2476
…all notifyOnBinding for template variables
BREAKING CHANGE:
Directives will use the Unbounded visibility by default, whereas before the change they used Self
Closes angular#2774 Closes angular#2989
Fixes the template compiler when running on the server.
Seems more accurate, and would allow `isJsObject()` to handle typical
`{}`-literals in dart, which could be useful
Closes angular#2995
BREAKING CHANGE Closes angular#2928
Expose the DI transformer for packages that have injectable objects but do not contain the application or angular views. Closes angular#2814
Fixes the following error in e2e tests: "Cannot set property style of \#<HTMLElement> which has only a getter". Closes angular#2874
Relying on ASI (automatic semicolon insertion) is allowed in TypeScript because JavaScript allows it. However, when we run clang-format it doesn’t understand that these statements are terminated with a newline and changes the indentation, in bad cases even breaking the code. Fixes angular#817
By binding the token `DOM_REFLECT_PROPERTIES_AS_ATTRIBUTES` provided by the dom_renderer module to `true` in the root injector (i.e. bootstrap()), all elements whose properties are set by angular will be reflected as attributes with the prefix "ng-reflect-". Fixes angular#2910
…etector bug in Dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or production
You can now run
gulp serve.e2e.prodto instantiate a task that watchesand compiles example and module files into the prod directory in dist
and then allows the code to be run via protractor.
…search.\n
Closes angular#2369