Reduce code duplication

Author: sebastianbergmann

PHP/CodeCoverage/Report/HTML/Renderer.php

@@ -219,29 +219,44 @@ protected function getBreadcrumbs(PHP_CodeCoverage_Report_Node $node)
 
         foreach ($path as $step) {
             if ($step !== $node) {
-                $breadcrumbs .= sprintf(
-                  '        <li><a href="%s.html">%s</a> <span class="divider">/</span></li>' . "\n",
-                  $step->getId(),
-                  $step->getName()
-                );
+                $breadcrumbs .= $this->getInactiveBreadcrumb($step);
             } else {
-                $breadcrumbs .= sprintf(
-                  '        <li class="active">%s</li>' . "\n",
-                  $step->getName()
+                $breadcrumbs .= $this->getActiveBreadcrumb(
+                  $step,
+                  $node instanceof PHP_CodeCoverage_Report_Node_Directory
                 );
-
-                if ($node instanceof PHP_CodeCoverage_Report_Node_Directory) {
-                    $breadcrumbs .= sprintf(
-                      '        <li>(<a href="%s.dashboard.html">Dashboard</a>)</li>' . "\n",
-                      $step->getId()
-                    );
-                }
             }
         }
 
         return $breadcrumbs;
     }
 
+    protected function getActiveBreadcrumb(PHP_CodeCoverage_Report_Node $node, $isDirectory)
+    {
+        $buffer = sprintf(
+          '        <li class="active">%s</li>' . "\n",
+          $node->getName()
+        );
+
+        if ($isDirectory) {
+            $buffer .= sprintf(
+              '        <li>(<a href="%s.dashboard.html">Dashboard</a>)</li>' . "\n",
+              $node->getId()
+            );
+        }
+
+        return $buffer;
+    }
+
+    protected function getInactiveBreadcrumb(PHP_CodeCoverage_Report_Node $node)
+    {
+        return sprintf(
+          '        <li><a href="%s.html">%s</a> <span class="divider">/</span></li>' . "\n",
+          $node->getId(),
+          $node->getName()
+        );
+    }
+
     protected function getCoverageBar($percent)
     {
         $level = $this->getColorLevel($percent);

PHP/CodeCoverage/Report/HTML/Renderer/Dashboard.php

@@ -228,29 +228,13 @@ protected function topProjectRisks(array $classes, $max = 10)
         return $buffer;
     }
 
-    protected function getBreadcrumbs(PHP_CodeCoverage_Report_Node $node)
+    protected function getActiveBreadcrumb(PHP_CodeCoverage_Report_Node $node, $isDirectory)
     {
-        $breadcrumbs = '';
-
-        $path = $node->getPathAsArray();
-
-        foreach ($path as $step) {
-            if ($step !== $node) {
-                $breadcrumbs .= sprintf(
-                  '        <li><a href="%s.html">%s</a> <span class="divider">/</span></li>' . "\n",
-                  $step->getId(),
-                  $step->getName()
-                );
-            } else {
-                $breadcrumbs .= sprintf(
-                  '        <li><a href="%s.html">%s</a></li>' . "\n" .
-                  '        <li class="active">(Dashboard)</li>' . "\n",
-                  $step->getId(),
-                  $step->getName()
-                );
-            }
-        }
-
-        return $breadcrumbs;
+        return sprintf(
+          '        <li><a href="%s.html">%s</a></li>' . "\n" .
+          '        <li class="active">(Dashboard)</li>' . "\n",
+          $node->getId(),
+          $node->getName()
+        );
     }
 }