Skip to content

Commit e0cee86

Browse files
committed
Fixes a variable leak and simplifies low score filtration
Signed-off-by: Christopher Rogers <[email protected]>
1 parent e5cf1f2 commit e0cee86

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

source/javascripts/app/search.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,13 @@
7171
if (this.value) {
7272
sections.hide();
7373
// results are sorted by score in descending order
74-
var tmpResults = index.search(this.value);
75-
var results = [];
76-
77-
// remove low score matches
78-
$.each(tmpResults, function (index, item) {
79-
if (item.score >= 0.0001) results.push(item);
80-
});
74+
var results = index.search(this.value);
8175

8276
if (results.length) {
83-
lastRef = null;
8477
resetHeaderLocations();
78+
var lastRef;
8579
$.each(results, function (index, item) {
80+
if (item.score <= 0.0001) return; // remove low-score results
8681
var itemRef = item.ref;
8782
$('#section-' + itemRef).show();
8883
// headers must be repositioned in the DOM

0 commit comments

Comments
 (0)