Bug#35000027 X DevAPI Don't clone Executable unless

needed

If Executable object is copied onto itself, it will not be cloned.

Change-Id: Id417714a9d5834d1f839733e5fcbbca2da553e4a

Author: silvakid

devapi/tests/bugs-t.cc

@@ -948,3 +948,19 @@ TEST_F(Bugs, Bug33352469)
   remove.bind("id", "2").execute();
   EXPECT_EQ(0U, coll.find().execute().count());
 }
+
+TEST_F(Bugs, Bug35000027)
+{
+  auto coll = get_sess().getSchema("test").createCollection("coll", true);
+  coll.remove("true").execute();
+  size_t nr_docs = 10000;
+  DbDoc doc(R"({"name":"foo", "bar": "baz" })");
+  auto add_task = coll.add(doc);
+  auto add_tast_2 = add_task.add(doc);
+  for (size_t i = 2; i < nr_docs; ++i) {
+    add_task = add_task.add(doc);
+    add_tast_2 = add_tast_2.add(doc);
+  }
+  EXPECT_EQ(nr_docs, add_task.execute().getAffectedItemsCount());
+  EXPECT_EQ(nr_docs, add_tast_2.execute().getAffectedItemsCount());
+}

include/mysqlx/devapi/executable.h

@@ -89,7 +89,7 @@ class Executable
 
   void reset(const Executable &other)
   {
-    m_impl.reset(other.m_impl->clone());
+    if (m_impl.get() != other.m_impl.get()) m_impl.reset(other.m_impl->clone());
   }
 
   void reset(const Executable &&other)