fix: add a flag for skipping the snapshot tools in order to skip them for the local part of the cloud builds

Author: DimitarTachev

plugins/NativeScriptSnapshotPlugin/index.js

@@ -97,6 +97,11 @@ exports.NativeScriptSnapshotPlugin = (function () {
 
     NativeScriptSnapshotPlugin.prototype.generate = function (webpackChunks) {
         const options = this.options;
+        if (options.skipSnapshotTools) {
+            console.log(`Skipping snapshot tools.`);
+            return Promise.resolve();
+        }
+
         const inputFiles = webpackChunks.map(chunk => join(options.webpackConfig.output.path, chunk.files[0]));
         const preprocessedInputFile = join(
             this.options.projectRoot,
@@ -113,7 +118,8 @@ exports.NativeScriptSnapshotPlugin = (function () {
             useLibs: options.useLibs,
             androidNdkPath: options.androidNdkPath,
             v8Version: options.v8Version,
-            snapshotInDocker: options.snapshotInDocker
+            snapshotInDocker: options.snapshotInDocker,
+            skipSnapshotTools: options.skipSnapshotTools
         }).then(() => {
             // Make the original files empty
             inputFiles.forEach(inputFile =>

plugins/NativeScriptSnapshotPlugin/options.json

@@ -42,6 +42,10 @@
     "snapshotInDocker": {
       "type": "boolean"
     },
+    "skipSnapshotTools": {
+      "type": "boolean",
+      "default": false
+    },
     "v8Version": {
       "type": "string"
     },

snapshot/android/project-snapshot-generator-cli-ags-parser.js

@@ -13,6 +13,10 @@ module.exports = function parseProjectSnapshotGeneratorArgs() {
         result.snapshotInDocker = parseBool(result.snapshotInDocker);
     }
 
+    if (result.skipSnapshotTools !== undefined) {
+        result.skipSnapshotTools = parseBool(result.skipSnapshotTools);
+    }
+
     if (result.install !== undefined) {
         result.install = parseBool(result.install);
     }

snapshot/android/project-snapshot-generator.js

@@ -210,6 +210,11 @@ ProjectSnapshotGenerator.prototype.validateAndroidRuntimeVersion = function () {
 }
 
 ProjectSnapshotGenerator.prototype.generate = function (generationOptions) {
+    if (generationOptions.skipSnapshotTools) {
+        console.log("Running snapshot generation with the following arguments: ");
+        return Promise.resolve();
+    }
+
     generationOptions = generationOptions || {};
 
     console.log("Running snapshot generation with the following arguments: ");

templates/webpack.angular.js

@@ -50,7 +50,8 @@ module.exports = env => {
         hmr, // --env.hmr,
         unitTesting, // --env.unitTesting
         verbose, // --env.verbose
-        snapshotInDocker // --env.snapshotInDocker
+        snapshotInDocker, // --env.snapshotInDocker
+        skipSnapshotTools // --env.skipSnapshotTools
     } = env;
 
     const isAnySourceMapEnabled = !!sourceMap || !!hiddenSourceMap;
@@ -309,7 +310,8 @@ module.exports = env => {
             ],
             projectRoot,
             webpackConfig: config,
-            snapshotInDocker
+            snapshotInDocker,
+            skipSnapshotTools
         }));
     }
 

templates/webpack.javascript.js

@@ -44,7 +44,8 @@ module.exports = env => {
         hmr, // --env.hmr,
         unitTesting, // --env.unitTesting,
         verbose, // --env.verbose
-        snapshotInDocker // --env.snapshotInDocker
+        snapshotInDocker, // --env.snapshotInDocker
+        skipSnapshotTools // --env.skipSnapshotTools
     } = env;
 
     const isAnySourceMapEnabled = !!sourceMap || !!hiddenSourceMap;
@@ -250,7 +251,8 @@ module.exports = env => {
             ],
             projectRoot,
             webpackConfig: config,
-            snapshotInDocker
+            snapshotInDocker,
+            skipSnapshotTools
         }));
     }
 

templates/webpack.typescript.js

@@ -45,7 +45,8 @@ module.exports = env => {
         hmr, // --env.hmr,
         unitTesting, // --env.unitTesting,
         verbose, // --env.verbose
-        snapshotInDocker // --env.snapshotInDocker
+        snapshotInDocker, // --env.snapshotInDocker
+        skipSnapshotTools // --env.skipSnapshotTools
     } = env;
     const isAnySourceMapEnabled = !!sourceMap || !!hiddenSourceMap;
     const externals = nsWebpack.getConvertedExternals(env.externals);
@@ -278,7 +279,8 @@ module.exports = env => {
             ],
             projectRoot,
             webpackConfig: config,
-            snapshotInDocker
+            snapshotInDocker,
+            skipSnapshotTools
         }));
     }
 

templates/webpack.vue.js

@@ -47,7 +47,8 @@ module.exports = env => {
         hiddenSourceMap, // --env.hiddenSourceMap
         unitTesting, // --env.unitTesting
         verbose, // --env.verbose
-        snapshotInDocker // --env.snapshotInDocker
+        snapshotInDocker, // --env.snapshotInDocker
+        skipSnapshotTools // --env.skipSnapshotTools
     } = env;
 
     const isAnySourceMapEnabled = !!sourceMap || !!hiddenSourceMap;
@@ -297,7 +298,8 @@ module.exports = env => {
             ],
             projectRoot,
             webpackConfig: config,
-            snapshotInDocker
+            snapshotInDocker,
+            skipSnapshotTools
         }));
     }