Skip to content

Commit 6637a4b

Browse files
committed
Log from within promise
1 parent faf6d03 commit 6637a4b

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

script/release

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ const zipAssets = () => {
4747
}
4848

4949
const createRelease = (assets) => {
50-
console.log('Creating new draft release')
51-
5250
const options = {
5351
uri: 'https://api.github.com/repos/electron/electron-api-demos/releases',
5452
headers: {
@@ -66,6 +64,8 @@ const createRelease = (assets) => {
6664
}
6765

6866
return new Promise((resolve, reject) => {
67+
console.log('Creating new draft release')
68+
6969
request.post(options, (error, response, body) => {
7070
if (error) {
7171
return reject(Error(`Request failed: ${error.message || error}`))
@@ -80,8 +80,6 @@ const createRelease = (assets) => {
8080
}
8181

8282
const uploadAsset = (release, asset) => {
83-
console.log(`Uploading ${asset.name} as release asset`)
84-
8583
const options = {
8684
uri: release.upload_url.replace(/\{.*$/, `?name=${asset.name}`),
8785
headers: {
@@ -93,13 +91,16 @@ const uploadAsset = (release, asset) => {
9391
}
9492

9593
return new Promise((resolve, reject) => {
94+
console.log(`Uploading ${asset.name} as release asset`)
95+
9696
const assetRequest = request.post(options, (error, response, body) => {
9797
if (error) {
9898
return reject(Error(`Uploading asset failed: ${error.message || error}`))
9999
}
100100
if (response.statusCode >= 400) {
101101
return reject(Error(`400+ response: ${response.statusCode}\n${util.inspect(body)}`))
102102
}
103+
103104
resolve(asset)
104105
})
105106
fs.createReadStream(asset.zip).pipe(assetRequest)
@@ -113,8 +114,6 @@ const uploadAssets = (release) => {
113114
}
114115

115116
const publishRelease = (release) => {
116-
console.log('Publishing release')
117-
118117
const options = {
119118
uri: release.draft.url,
120119
headers: {
@@ -127,6 +126,8 @@ const publishRelease = (release) => {
127126
}
128127

129128
return new Promise((resolve, reject) => {
129+
console.log('Publishing release')
130+
130131
request.post(options, (error, response, body) => {
131132
if (error) {
132133
return reject(Error(`Request failed: ${error.message || error}`))

0 commit comments

Comments
 (0)