glayzzle#70 fix errors arguments list

Author: ichiriac

RELEASE.md

@@ -1,5 +1,9 @@
 # Releases
 
+## 2.1.0 : pending
+
+- Fix AST errors on suppressErrors
+
 ## 2.0.0 : (2017-03-04)
 
 - Update AST for operators, unify bin/bool/coalesce nodes

src/parser/function.js

@@ -184,11 +184,13 @@ module.exports = {
     if (this.token !== ')') {
       while(this.token != this.EOF) {
         var argument = this.read_argument_list();
-        result.push(argument);
-        if (argument.kind === 'variadic') {
-          wasVariadic = true;
-        } else if (wasVariadic) {
-          this.raiseError('Unexpected argument after a variadic argument');
+        if (argument) {
+          result.push(argument);
+          if (argument.kind === 'variadic') {
+            wasVariadic = true;
+          } else if (wasVariadic) {
+            this.raiseError('Unexpected argument after a variadic argument');
+          }
         }
         if (this.token === ',') {
           this.next();

test/gracefulTests.js

@@ -70,6 +70,25 @@ describe('Test graceful mode', function() {
       ast.children[0].kind.should.be.exactly('interface');
     });
 
+    it('test function arguments', function () {
+      // test.parser.debug = true;
+      var ast = test.parseEval([
+        '$foo->bar($arg, );',
+        '$foo = new bar($baz, ,$foo);'
+      ].join('\n'));
+      var callNode = ast.children[0];
+      callNode.kind.should.be.exactly('call');
+      callNode.what.kind.should.be.exactly('propertylookup');
+      callNode.arguments.length.should.be.exactly(1);
+      callNode.arguments[0].name.should.be.exactly('arg');
+      var assignNode = ast.children[1];
+      assignNode.kind.should.be.exactly('assign');
+      assignNode.right.kind.should.be.exactly('new');
+      assignNode.right.arguments[0].name.should.be.exactly('baz');
+      // the supressError mode cant guarantee $foo to be included into the arguments list
+    });
+
+
   });
 
 });