Fix RequestBuilderTest#testAddOrReplaceCookies

Author: slandelle

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClient.java

@@ -186,9 +186,9 @@ public <T> ListenableFuture<T> executeRequest(Request request, AsyncHandler<T> h
         List<Cookie> cookies = config.getCookieStore().get(request.getUri());
         if (!cookies.isEmpty()) {
           RequestBuilder requestBuilder = new RequestBuilder(request);
-          for (Cookie cookie : cookies)
+          for (Cookie cookie : cookies) {
             requestBuilder.addOrReplaceCookie(cookie);
-
+          }
           request = requestBuilder.build();
         }
       } catch (Exception e) {

client/src/main/java/org/asynchttpclient/RequestBuilderBase.java

@@ -306,6 +306,11 @@ public T addCookie(Cookie cookie) {
     return asDerivedType();
   }
 
+  /**
+   * Add/replace a cookie based on its name
+   * @param cookie the new cookie
+   * @return this
+   */
   public T addOrReplaceCookie(Cookie cookie) {
     String cookieKey = cookie.name();
     boolean replace = false;

client/src/test/java/org/asynchttpclient/RequestBuilderTest.java

@@ -132,7 +132,7 @@ public void testSetHeaders() {
     assertEquals(requestBuilder.headers.get("Content-Type"), "application/json", "header value incorrect");
   }
 
-  @Test(enabled = false)
+  @Test
   public void testAddOrReplaceCookies() {
     RequestBuilder requestBuilder = new RequestBuilder();
     Cookie cookie = new DefaultCookie("name", "value");
@@ -156,7 +156,7 @@ public void testAddOrReplaceCookies() {
     assertEquals(requestBuilder.cookies.size(), 1, "cookies size should remain 1 as we just replaced a cookie with same name");
     assertEquals(requestBuilder.cookies.get(0), cookie2, "cookie does not match");
 
-    Cookie cookie3 = new DefaultCookie("name", "value");
+    Cookie cookie3 = new DefaultCookie("name2", "value");
     cookie3.setDomain("google.com");
     cookie3.setPath("/");
     cookie3.setMaxAge(1000);