Improve skip condition

Author: sebastianbergmann

tests/tests/CodeCoverageTest.php

@@ -16,6 +16,7 @@
 use SebastianBergmann\CodeCoverage\Driver\Driver;
 use SebastianBergmann\CodeCoverage\Driver\PHPDBG;
 use SebastianBergmann\CodeCoverage\Driver\Xdebug;
+use SebastianBergmann\Environment\Runtime;
 
 /**
  * @covers SebastianBergmann\CodeCoverage\CodeCoverage
@@ -29,54 +30,27 @@ class CodeCoverageTest extends TestCase
 
     protected function setUp()
     {
-        $this->coverage = new CodeCoverage;
-    }
+        $runtime = new Runtime;
 
-    public function testCanBeConstructedForXdebugWithoutGivenFilterObject()
-    {
-        if (PHP_SAPI == 'phpdbg') {
-            $this->markTestSkipped('Requires PHP CLI and Xdebug');
+        if (!$runtime->canCollectCodeCoverage()) {
+            $this->markTestSkipped('No code coverage driver available');
         }
 
-        $this->assertAttributeInstanceOf(
-            Xdebug::class,
-            'driver',
-            $this->coverage
-        );
-
-        $this->assertAttributeInstanceOf(
-            Filter::class,
-            'filter',
-            $this->coverage
-        );
+        $this->coverage = new CodeCoverage;
     }
 
-    public function testCanBeConstructedForXdebugWithGivenFilterObject()
+    public function testCanBeConstructedWithoutGivenFilterObject()
     {
-        if (PHP_SAPI == 'phpdbg') {
-            $this->markTestSkipped('Requires PHP CLI and Xdebug');
+        if (extension_loaded('xdebug')) {
+            $expectedClass = Xdebug::class;
         }
 
-        $filter   = new Filter;
-        $coverage = new CodeCoverage(null, $filter);
-
-        $this->assertAttributeInstanceOf(
-            Xdebug::class,
-            'driver',
-            $coverage
-        );
-
-        $this->assertSame($filter, $coverage->filter());
-    }
-
-    public function testCanBeConstructedForPhpdbgWithoutGivenFilterObject()
-    {
-        if (PHP_SAPI != 'phpdbg') {
-            $this->markTestSkipped('Requires PHPDBG');
+        if (PHP_SAPI === 'phpdbg') {
+            $expectedClass = PHPDBG::class;
         }
 
         $this->assertAttributeInstanceOf(
-            PHPDBG::class,
+            $expectedClass,
             'driver',
             $this->coverage
         );
@@ -88,17 +62,13 @@ public function testCanBeConstructedForPhpdbgWithoutGivenFilterObject()
         );
     }
 
-    public function testCanBeConstructedForPhpdbgWithGivenFilterObject()
+    public function testCanBeConstructedWithGivenFilterObject()
     {
-        if (PHP_SAPI != 'phpdbg') {
-            $this->markTestSkipped('Requires PHPDBG');
-        }
-
         $filter   = new Filter;
         $coverage = new CodeCoverage(null, $filter);
 
         $this->assertAttributeInstanceOf(
-            PHPDBG::class,
+            Xdebug::class,
             'driver',
             $coverage
         );