Merge branch '221-max-wal-senders' into 'master'

fix: use prod max_wal_senders for the sync instance and clones if it has not a default value (postgres-ai#221)

Closes postgres-ai#221

See merge request postgres-ai/database-lab!283

Author: agneum

pkg/retrieval/engine/postgres/physical/physical.go

@@ -48,6 +48,7 @@ var (
 		"max_locks_per_xact":     "max_locks_per_transaction",
 		"max_worker_processes":   "max_worker_processes",
 		"track_commit_timestamp": "track_commit_timestamp",
+		"max_wal_senders":        "max_wal_senders",
 	}
 )
 

pkg/retrieval/engine/postgres/physical/physical_test.go

@@ -19,17 +19,19 @@ wal_level setting:                    logical
 wal_log_hints setting:                on
 max_connections setting:              500
 max_worker_processes setting:         8
-max_prepared_xacts setting:           0
+max_prepared_xacts setting:           3
 max_locks_per_xact setting:           128
 track_commit_timestamp setting:       off
+max_wal_senders setting:              15
 `)
 
 	expectedSettings := map[string]string{
 		"max_connections":           "500",
 		"max_locks_per_transaction": "128",
-		"max_prepared_transactions": "0",
+		"max_prepared_transactions": "3",
 		"max_worker_processes":      "8",
 		"track_commit_timestamp":    "off",
+		"max_wal_senders":           "15",
 	}
 
 	settings, err := extractControlDataParams(context.Background(), controlDataOutput)

test/3.physical_walg.sh

@@ -50,7 +50,8 @@ set -euxo pipefail # ----
 sed -ri "s/:13/:${POSTGRES_VERSION}/g"  ~/.dblab/server.yml
 # reduce shared_buffers (optional)
 sed -ri "s/^(\s*)(shared_buffers:.*$)/\1shared_buffers: 512MB/" ~/.dblab/server.yml
-
+# skip snapshotting on start to replace some Postgres parameters after PGDATA receiving
+sed -ri "s/^(\s*)(skipStartSnapshot:.*$)/\1skipStartSnapshot: true/" ~/.dblab/server.yml
 
 ## Launch Database Lab server
 sudo docker run \
@@ -75,6 +76,27 @@ for i in {1..30}; do
   sleep 10
 done
 
+# Test increasing default configuration parameters from pg_controldata. If the Database Lab Engine will start successfully, the test is passed.
+sudo docker exec -it dblab_server bash -c 'echo -e "\nmax_connections = 300" >> /var/lib/dblab/dblab_pool/data/postgresql.dblab.postgresql.conf'
+sudo docker exec -it dblab_server bash -c 'echo "max_prepared_transactions = 5" >> /var/lib/dblab/dblab_pool/data/postgresql.dblab.postgresql.conf'
+sudo docker exec -it dblab_server bash -c 'echo "max_locks_per_transaction = 100" >> /var/lib/dblab/dblab_pool/data/postgresql.dblab.postgresql.conf'
+sudo docker exec -it dblab_server bash -c 'echo "max_worker_processes = 12" >> /var/lib/dblab/dblab_pool/data/postgresql.dblab.postgresql.conf'
+sudo docker exec -it dblab_server bash -c 'echo "track_commit_timestamp = on" >> /var/lib/dblab/dblab_pool/data/postgresql.dblab.postgresql.conf'
+sudo docker exec -it dblab_server bash -c 'echo "max_wal_senders = 15" >> /var/lib/dblab/dblab_pool/data/postgresql.dblab.postgresql.conf'
+
+# Enable snapshotting on start to make a new snapshot
+sed -ri "s/^(\s*)(skipStartSnapshot:.*$)/\1skipStartSnapshot: false/" ~/.dblab/server.yml
+
+sudo docker restart dblab_server
+
+# Check the Database Lab Engine logs
+sudo docker logs dblab_server -f 2>&1 | awk '{print "[CONTAINER dblab_server]: "$0}' &
+
+### Waiting for the Database Lab Engine initialization.
+for i in {1..30}; do
+  curl http://localhost:2345 > /dev/null 2>&1 && break || echo "dblab is not ready yet"
+  sleep 10
+done
 
 ### Step 3. Start cloning
 
@@ -101,6 +123,9 @@ dblab clone create \
   --password secret_password \
   --id testclone
 
+PGPASSWORD=secret_password psql \
+  "host=localhost port=6000 user=dblab_user_1 dbname=test" -c 'show max_wal_senders'
+
 # Connect to a clone and check the available table
 PGPASSWORD=secret_password psql \
   "host=localhost port=6000 user=dblab_user_1 dbname=postgres" -c '\dt+'