Addressed remaining comments

Author: Patrick Glinsman

.kokoro/secrets-example.sh

@@ -100,6 +100,10 @@ export REDIS_PORT=
 export GOOGLE_PUBSUB_SUBSCRIPTION=php-example-subscription
 export GOOGLE_PUBSUB_TOPIC=php-example-topic
 
+# Security Center
+export GOOGLE_ORGANIZATION_ID=
+export GOOGLE_PUBSUB_TOPIC=php-example-topic
+
 # Spanner
 export GOOGLE_SPANNER_INSTANCE_ID=
 export GOOGLE_SPANNER_DATABASE_ID=test-database

securitycenter/src/create_notification.php

@@ -25,6 +25,7 @@
 // [START scc_create_notification_config]
 use Google\Cloud\SecurityCenter\V1\SecurityCenterClient;
 use Google\Cloud\SecurityCenter\V1\NotificationConfig;
+use Google\Cloud\SecurityCenter\V1\NotificationConfig\StreamingConfig;
 
 /** Uncomment and populate these variables in your code */
 // $organizationId = "{your-org-id}";
@@ -36,12 +37,12 @@
 $organizationName = $securityCenterClient::organizationName($organizationId);
 $pubsubTopic = $securityCenterClient::topicName($projectId, $topicName);
 
-$streamingConfig = new NotificationConfig\StreamingConfig();
+$streamingConfig = new StreamingConfig();
 $streamingConfig->setFilter("state = \"ACTIVE\"");
-$notificationConfig = new NotificationConfig();
-$notificationConfig->setDescription('A sample notification config');
-$notificationConfig->setPubsubTopic($pubsubTopic);
-$notificationConfig->setStreamingConfig($streamingConfig);
+$notificationConfig = (new NotificationConfig())
+    ->setDescription('A sample notification config')
+    ->setPubsubTopic($pubsubTopic)
+    ->setStreamingConfig($streamingConfig);
 
 $response = $securityCenterClient->createNotificationConfig(
     $organizationName,
@@ -50,5 +51,4 @@
 );
 printf('Notification config was created: %s', $response->getName());
 
-$securityCenterClient->close();
-// [END scc_create_notification_config]
+// [END scc_create_notification_config]

securitycenter/src/delete_notification.php

@@ -38,5 +38,4 @@
 $response = $securityCenterClient->deleteNotificationConfig($notificationConfigName);
 print('Notification config was deleted');
 
-$securityCenterClient->close();
-// [END scc_delete_notification_config]
+// [END scc_delete_notification_config]

securitycenter/src/get_notification.php

@@ -38,5 +38,4 @@
 $response = $securityCenterClient->getNotificationConfig($notificationConfigName);
 printf('Notification config was retrieved: %s', $response->getName());
 
-$securityCenterClient->close();
-// [END scc_get_notification_config]
+// [END scc_get_notification_config]

securitycenter/src/list_notification.php

@@ -31,11 +31,10 @@
 $securityCenterClient = new SecurityCenterClient();
 $organizationName = $securityCenterClient::organizationName($organizationId);
 
-$pagedResponse = $securityCenterClient->listNotificationConfigs($organizationName);
-foreach ($pagedResponse->iterateAllElements() as $element) {
-    printf('Found notification config %s', $element->getName());
+foreach ($securityCenterClient->listNotificationConfigs($organizationName) as $element) {
+    printf('Found notification config %s' . PHP_EOL, $element->getName());
 }
 
 print('Notification configs were listed');
-$securityCenterClient->close();
-// [END scc_list_notification_configs]
+
+// [END scc_list_notification_configs]

securitycenter/src/receive_notification.php

@@ -39,4 +39,5 @@
     // Acknowledge the Pub/Sub message has been received, so it will not be pulled multiple times.
     $subscription->acknowledge($message);
 }
-// [END scc_receive_notifications]
+
+// [END scc_receive_notifications]

securitycenter/src/update_notification.php

@@ -45,14 +45,12 @@
 $streamingConfig->setFilter("state = \"ACTIVE\"");
 $fieldMask = new FieldMask();
 $fieldMask->setPaths(['description', 'pubsub_topic']);
-$notificationConfig = new NotificationConfig();
-$notificationConfig
+$notificationConfig = (new NotificationConfig())
     ->setName($notificationConfigName)
     ->setDescription('Updated description.')
     ->setPubsubTopic($pubsubTopic);
 
 $response = $securityCenterClient->updateNotificationConfig($notificationConfig, [$fieldMask]);
 printf('Notification config was updated: %s', $response->getName());
 
-$securityCenterClient->close();
-// [END scc_update_notification_config]
+// [END scc_update_notification_config]

securitycenter/test/securitycenterTest.php

@@ -117,7 +117,7 @@ private static function getOrganizationId()
 
     private static function getTopicName()
     {
-        return self::requireEnv('GOOGLE_TOPIC_ID');
+        return self::requireEnv('GOOGLE_PUBSUB_TOPIC');
     }
 
     private static function randomNotificationId()