removing warning 4996 suppressions

Author: AlonsoMondal

include/json/writer.h

@@ -164,10 +164,6 @@ class JSON_API Writer {
  * \sa Reader, Value
  * \deprecated Use StreamWriterBuilder.
  */
-#if defined(_MSC_VER)
-#pragma warning(push)
-#pragma warning(disable : 4996) // Deriving from deprecated class
-#endif
 class JSON_API FastWriter
     : public Writer {
 public:
@@ -196,9 +192,6 @@ class JSON_API FastWriter
   bool dropNullPlaceholders_{false};
   bool omitEndingLineFeed_{false};
 };
-#if defined(_MSC_VER)
-#pragma warning(pop)
-#endif
 
 /** \brief Writes a Value in <a HREF="http://www.json.org">JSON</a> format in a
  *human friendly way.
@@ -224,10 +217,6 @@ class JSON_API FastWriter
  * \sa Reader, Value, Value::setComment()
  * \deprecated Use StreamWriterBuilder.
  */
-#if defined(_MSC_VER)
-#pragma warning(push)
-#pragma warning(disable : 4996) // Deriving from deprecated class
-#endif
 class JSON_API
     StyledWriter : public Writer {
 public:
@@ -264,9 +253,6 @@ class JSON_API
   unsigned int indentSize_{3};
   bool addChildValues_{false};
 };
-#if defined(_MSC_VER)
-#pragma warning(pop)
-#endif
 
 /** \brief Writes a Value in <a HREF="http://www.json.org">JSON</a> format in a
  human friendly way,
@@ -293,10 +279,6 @@ class JSON_API
  * \sa Reader, Value, Value::setComment()
  * \deprecated Use StreamWriterBuilder.
  */
-#if defined(_MSC_VER)
-#pragma warning(push)
-#pragma warning(disable : 4996) // Deriving from deprecated class
-#endif
 class JSON_API
     StyledStreamWriter {
 public:
@@ -339,9 +321,6 @@ class JSON_API
   bool addChildValues_ : 1;
   bool indented_ : 1;
 };
-#if defined(_MSC_VER)
-#pragma warning(pop)
-#endif
 
 #if defined(JSON_HAS_INT64)
 String JSON_API valueToString(Int value);

src/jsontestrunner/main.cpp

@@ -6,9 +6,6 @@
 #if defined(__GNUC__)
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#elif defined(_MSC_VER)
-#pragma warning(disable : 4996)
-#endif
 
 /* This executable is used for testing parser/writer using real JSON files.
  */

src/lib_json/json_reader.cpp

@@ -37,11 +37,6 @@
 #endif //_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES
 #endif //_MSC_VER
 
-#if defined(_MSC_VER)
-// Disable warning about strdup being deprecated.
-#pragma warning(disable : 4996)
-#endif
-
 // Define JSONCPP_DEPRECATED_STACK_LIMIT as an appropriate integer at compile
 // time to change the stack limit
 #if !defined(JSONCPP_DEPRECATED_STACK_LIMIT)

src/lib_json/json_writer.cpp

@@ -78,11 +78,6 @@
 #endif
 #endif
 
-#if defined(_MSC_VER)
-// Disable warning about strdup being deprecated.
-#pragma warning(disable : 4996)
-#endif
-
 namespace Json {
 
 #if __cplusplus >= 201103L || (defined(_CPPLIB_VER) && _CPPLIB_VER >= 520)

src/test_lib_json/main.cpp

@@ -6,9 +6,6 @@
 #if defined(__GNUC__)
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#elif defined(_MSC_VER)
-#pragma warning(disable : 4996)
-#endif
 
 #include "fuzz.h"
 #include "jsontest.h"