Retry removing directories on Windows

Kasper Laudrup · Kasper Laudrup · commit 6bc77966ad7c · 2019-08-08T15:59:02.000+02:00
On Windows removing a directory can fail if other processes have a
handle to it. This has been "solved" with a retry hack when moving
directories, so use the same hack when removing directories.
diff --git a/Source/cmFileCommand.cxx b/Source/cmFileCommand.cxx
@@ -1422,7 +1422,7 @@ bool cmFileCommand::HandleRemove(std::vector<std::string> const& args,
 
     if (cmSystemTools::FileIsDirectory(fileName) &&
         !cmSystemTools::FileIsSymlink(fileName) && recurse) {
-      cmSystemTools::RemoveADirectory(fileName);
+      cmSystemTools::RepeatedRemoveDirectory(fileName);
     } else {
       cmSystemTools::RemoveFile(fileName);
     }

Original file line number	Diff line number	Diff line change
`@@ -1422,7 +1422,7 @@ bool cmFileCommand::HandleRemove(std::vector<std::string> const& args,`
`1422`	`1422`
`1423`	`1423`	`if (cmSystemTools::FileIsDirectory(fileName) &&`
`1424`	`1424`	`!cmSystemTools::FileIsSymlink(fileName) && recurse) {`
`1425`		`- cmSystemTools::RemoveADirectory(fileName);`
	`1425`	`+ cmSystemTools::RepeatedRemoveDirectory(fileName);`
`1426`	`1426`	`} else {`
`1427`	`1427`	`cmSystemTools::RemoveFile(fileName);`
`1428`	`1428`	`}`