Skip to content

Commit 297b332

Browse files
Peter Hartmannphartmann
Peter Hartmann
authored andcommitted
[BB10-internal] QNetworkAccessManager: return default configuration if without session
... instead of a zero configuration. That is documented already for QNetworkAccessManager::setConfiguration(). Task-number: QTBUG-28973 (cherry picked from commit 1df2b9ee2376e132a6bf9596097351f0c79e6b73) Change-Id: I074265525485b63adecad90f16fd4e2acf6d7b16 Signed-off-by: Peter Hartmann <[email protected]>
1 parent bb00ac8 commit 297b332

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/network/access/qnetworkaccessmanager.cpp

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -773,10 +773,12 @@ QNetworkConfiguration QNetworkAccessManager::configuration() const
773773
Q_D(const QNetworkAccessManager);
774774

775775
QSharedPointer<QNetworkSession> session(d->getNetworkSession());
776-
if (session)
776+
if (session) {
777777
return session->configuration();
778-
else
779-
return QNetworkConfiguration();
778+
} else {
779+
QNetworkConfigurationManager manager;
780+
return manager.defaultConfiguration();
781+
}
780782
}
781783

782784
/*!
@@ -799,13 +801,12 @@ QNetworkConfiguration QNetworkAccessManager::activeConfiguration() const
799801
Q_D(const QNetworkAccessManager);
800802

801803
QSharedPointer<QNetworkSession> networkSession(d->getNetworkSession());
804+
QNetworkConfigurationManager manager;
802805
if (networkSession) {
803-
QNetworkConfigurationManager manager;
804-
805806
return manager.configurationFromIdentifier(
806807
networkSession->sessionProperty(QLatin1String("ActiveConfiguration")).toString());
807808
} else {
808-
return QNetworkConfiguration();
809+
return manager.defaultConfiguration();
809810
}
810811
}
811812

0 commit comments

Comments
 (0)