Skip to content

Commit 3e29d87

Browse files
Shane KearnsQt by Nokia
Shane Kearns
authored and
Qt by Nokia
committed
Fix performance problem with NTLM auth in http POST
A combination of other fixes resulted in authentication credentials with a blank username & password being incorrectly added to the cache only for NTLM. This caused authentication to be attempted with blank credentials first (which would fail), before the authenticationRequired signal was emitted. It caused a performance issue because of the extra 2 requests to the server (and possibly delays inserted by the server following a failed login) Task-number: ou1cimx1#985786 Change-Id: Ic588a20cfe7c24d5e60cd384caff0673a587e484 Reviewed-by: Martin Petersson <[email protected]> (cherry picked from commit 3c3ea9a869086ebb02a5d0c475754f6a184a50ab)
1 parent 327fa27 commit 3e29d87

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/network/kernel/qauthenticator.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,8 @@ void QAuthenticatorPrivate::parseHttpResponse(const QList<QPair<QByteArray, QByt
392392
break;
393393
case Ntlm:
394394
// #### extract from header
395+
if (user.isEmpty() && password.isEmpty())
396+
phase = Done;
395397
break;
396398
case DigestMd5: {
397399
this->options[QLatin1String("realm")] = realm = QString::fromLatin1(options.value("realm"));

0 commit comments

Comments
 (0)