Performance fix for QScriptString.

nierob · nierob · commit 91a1eda4642b · 2011-05-04T10:59:20.000+02:00
QScritpString should use symbols as an implementation to increase chance
to hit fast cases, for example for equals algorithm.

Reviewed-by: Caio Marcelo de Oliveira Filho
diff --git a/src/script/api/qscriptstring_impl_p.h b/src/script/api/qscriptstring_impl_p.h
@@ -50,8 +50,10 @@ QScriptStringPrivate::QScriptStringPrivate()
 {}
 
 QScriptStringPrivate::QScriptStringPrivate(QScriptEnginePrivate *engine, v8::Handle<v8::String> str)
-    : m_engine(engine), m_string(v8::Persistent<v8::String>::New(str))
+    : m_engine(engine)
 {
+    const v8::String::Utf8Value utf8(str);
+    m_string = v8::Persistent<v8::String>::New(v8::String::NewSymbol(*utf8, utf8.length()));
     Q_ASSERT(!m_string.IsEmpty());
     m_engine->registerString(this);
 }

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,10 @@ QScriptStringPrivate::QScriptStringPrivate()`
`50`	`50`	`{}`
`51`	`51`
`52`	`52`	`QScriptStringPrivate::QScriptStringPrivate(QScriptEnginePrivate *engine, v8::Handle<v8::String> str)`
`53`		`- : m_engine(engine), m_string(v8::Persistent<v8::String>::New(str))`
	`53`	`+ : m_engine(engine)`
`54`	`54`	`{`
	`55`	`+ const v8::String::Utf8Value utf8(str);`
	`56`	`+ m_string = v8::Persistent<v8::String>::New(v8::String::NewSymbol(*utf8, utf8.length()));`
`55`	`57`	`Q_ASSERT(!m_string.IsEmpty());`
`56`	`58`	`m_engine->registerString(this);`
`57`	`59`	`}`