Expose the script id from StackFrame.

Currently V8 API use two ways for a script recognition;
- script file name
- id
The first one is not unique and the second is accessible only from
v8::Script object which makes it unusable.

This patch exposes script id from frame so we can do deterministic
association between them.

Author: nierob

src/3rdparty/v8/include/v8.h

@@ -773,7 +773,12 @@ class V8EXPORT StackTrace {
     kIsEval = 1 << 4,
     kIsConstructor = 1 << 5,
     kScriptNameOrSourceURL = 1 << 6,
+#ifdef QT_BUILD_SCRIPT_LIB
+    kScriptId = 1 << 7,
+    kOverview = kLineNumber | kColumnOffset | kScriptName | kFunctionName | kScriptId,
+#else
     kOverview = kLineNumber | kColumnOffset | kScriptName | kFunctionName,
+#endif
     kDetailed = kOverview | kIsEval | kIsConstructor | kScriptNameOrSourceURL
   };
 
@@ -833,6 +838,14 @@ class V8EXPORT StackFrame {
    */
   Local<String> GetScriptName() const;
 
+#ifdef QT_BUILD_SCRIPT_LIB
+  /**
+   * Returns the id of the resource that contains the script for the
+   * function for this StackFrame.
+   */
+  Local<Value> GetScriptId() const;
+#endif
+
   /**
    * Returns the name of the resource that contains the script for the
    * function for this StackFrame or sourceURL value if the script name

src/3rdparty/v8/src/api.cc

@@ -1942,6 +1942,20 @@ Local<String> StackFrame::GetScriptName() const {
   return scope.Close(Local<String>::Cast(Utils::ToLocal(name)));
 }
 
+#ifdef QT_BUILD_SCRIPT_LIB
+Local<Value> StackFrame::GetScriptId() const {
+  i::Isolate* isolate = i::Isolate::Current();
+  if (IsDeadCheck(isolate, "v8::StackFrame::GetScriptId()")) return Local<Value>();
+  ENTER_V8(isolate);
+  HandleScope scope;
+  i::Handle<i::JSObject> self = Utils::OpenHandle(this);
+  i::Handle<i::Object> id = GetProperty(self, "scriptId");
+  if (!id->IsNumber()) {
+    return Local<Value>();
+  }
+  return scope.Close(Utils::ToLocal(id));
+}
+#endif
 
 Local<String> StackFrame::GetScriptNameOrSourceURL() const {
   i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();

src/3rdparty/v8/src/top.cc

@@ -197,6 +197,9 @@ Handle<JSArray> Isolate::CaptureCurrentStackTrace(
   Handle<String> column_key = factory()->LookupAsciiSymbol("column");
   Handle<String> line_key = factory()->LookupAsciiSymbol("lineNumber");
   Handle<String> script_key = factory()->LookupAsciiSymbol("scriptName");
+#ifdef QT_BUILD_SCRIPT_LIB
+  Handle<String> script_id_key = factory()->LookupAsciiSymbol("scriptId");
+#endif
   Handle<String> name_or_source_url_key =
       factory()->LookupAsciiSymbol("nameOrSourceURL");
   Handle<String> script_name_or_source_url_key =
@@ -249,6 +252,13 @@ Handle<JSArray> Isolate::CaptureCurrentStackTrace(
         SetLocalPropertyNoThrow(stackFrame, script_key, script_name);
       }
 
+#ifdef QT_BUILD_SCRIPT_LIB
+      if (options & StackTrace::kScriptId) {
+        Handle<Object> script_id(script->id());
+        SetLocalPropertyNoThrow(stackFrame, script_id_key, script_id);
+      }
+#endif
+
       if (options & StackTrace::kScriptNameOrSourceURL) {
         Handle<Object> script_name(script->name(), this);
         Handle<JSValue> script_wrapper = GetScriptWrapper(script);