Skip to content

Commit 5362b8a

Browse files
committed
Fix events to go through the navigation bar layers
Summary: Here is a showcase of 2 bugs that are fixed with this PR: touchability of title, touchability of overlapped top-right positionned (under the navbar). (i'm using the inspector) ![bug](https://cloud.githubusercontent.com/assets/211411/11809475/7b6ba71a-a327-11e5-90cf-cbe58637c447.gif) I have a navbar with a back button, a Title area with a **Green Circle**, a Right area with nothing inside. In my Screen View, I've positioned in absolute a **Red Rectangle** just on the top-right corner under the navbar. I want my **Green Circle** and **Red Rectangle** to be touchable but in current React Native version, this is not possible: as shown in the gif, the 3 LeftButton/Title/RightButton wrapper View are **catching the touch events**. My PR allows events to go through these wrapper View. **After the fix:** ![nobug](https://cloud.githubusercontent.com/assets/211411/11809590/3b803994-a328-11e5-81f7-c1a3bab45e1b.gif) Complementary Notes: - in the case of the Red Rectangle, only the lower part of it i Closes facebook#4786 Reviewed By: svcscm Differential Revision: D2760205 Pulled By: androidtrunkagent fb-gh-sync-id: 55bb141c8f61ab537ff9e832b65b04cb904dfeb9
1 parent 30999e3 commit 5362b8a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Libraries/CustomComponents/Navigator/NavigatorNavigationBar.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ var NavigatorNavigationBar = React.createClass({
195195
ref={(ref) => {
196196
this._components[componentName] = this._components[componentName].set(route, ref);
197197
}}
198+
pointerEvents="box-none"
198199
style={initialStage[componentName]}>
199200
{content}
200201
</View>

0 commit comments

Comments
 (0)