Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.17-stable
Choose a base ref
...
head repository: ProjectSeptemberInc/react-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.17-stable
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 4 files changed
  • 1 contributor

Commits on Dec 23, 2015

  1. Fixes error when navigationBar is set back to null

    @gre
    gre committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    b8dcfbc View commit details
    Browse the repository at this point in the history

  2. use typeof for checking function

    @gre
    gre committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    5e24aa6 View commit details
    Browse the repository at this point in the history

  3. Fix events to go through the navigation bar layers 

    Summary:
Here is a showcase of 2 bugs that are fixed with this PR: touchability of title, touchability of overlapped top-right positionned (under the navbar).

(i'm using the inspector)

![bug](https://cloud.githubusercontent.com/assets/211411/11809475/7b6ba71a-a327-11e5-90cf-cbe58637c447.gif)

I have a navbar with a back button, a Title area with a **Green Circle**, a Right area with nothing inside.
In my Screen View, I've positioned in absolute a **Red Rectangle** just on the top-right corner under the navbar.

I want my **Green Circle** and **Red Rectangle** to be touchable but in current React Native version, this is not possible: as shown in the gif, the 3 LeftButton/Title/RightButton wrapper View are **catching the touch events**. My PR allows events to go through these wrapper View.

**After the fix:**

![nobug](https://cloud.githubusercontent.com/assets/211411/11809590/3b803994-a328-11e5-81f7-c1a3bab45e1b.gif)

Complementary Notes:
- in the case of the Red Rectangle, only the lower part of it i
Closes #4786

Reviewed By: svcscm

Differential Revision: D2760205

Pulled By: androidtrunkagent

fb-gh-sync-id: 55bb141c8f61ab537ff9e832b65b04cb904dfeb9
    @gre
    gre committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    5362b8a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'gre/patch-5' into 0.17-stable

    @gre
    gre committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    d8d3982 View commit details
    Browse the repository at this point in the history

  5. single quote

    @gre
    gre committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    f6b959f View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2015

  1. Update Navigator.js

    @gre
    gre committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    cb2bcc0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'gre/patch-5' into 0.17-stable

    @gre
    gre committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    e7b4e01 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2016

  1. configureScene: add routeStack in second argument

    @gre
    gre committed Jan 11, 2016
    Configuration menu
    Copy the full SHA
    7f6e45a View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2016

  1. add ScrollResponder#scrollResponderZoomToWithoutAnimation

    @gre
    gre committed Jan 12, 2016
    Configuration menu
    Copy the full SHA
    2069c6e View commit details
    Browse the repository at this point in the history

  2. Prefer using the same scrollResponderZoomTo with a second animated arg

    @gre
    gre committed Jan 12, 2016
    Configuration menu
    Copy the full SHA
    db99668 View commit details
    Browse the repository at this point in the history
Loading