Move window.flip outside of the on_draw handler.

on_draw event handlers should just do drawing. It
is the calling code's responsibility to perform the
buffer flipping.

Author: adamlwgriffiths

examples/create_window/main.py

@@ -64,15 +64,15 @@ def step( self, dt ):
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
 
+        # display the frame buffer
+        self.window.flip()
+
     def on_draw( self ):
         # clear our frame buffer and depth buffer
         glClear( GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT )
 
         # render the fps
         self.fps_display.draw()
-
-        # display the frame buffer
-        self.window.flip()
 
 
 def main():

examples/fps_camera/main.py

@@ -161,6 +161,9 @@ def step( self, dt ):
         # manually dispatch the on_draw event
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
+        
+        # display the frame buffer
+        self.window.flip()
 
     def on_draw( self ):
         # render our scene
@@ -171,9 +174,6 @@ def on_draw( self ):
 
         # render our help text
         self.help_label.draw()
-        
-        # display the frame buffer
-        self.window.flip()
 
     def move_camera( self, dt ):
         # update the Camera

examples/low_level/main.py

@@ -146,15 +146,15 @@ def step( self, dt ):
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
 
+        # display the frame buffer
+        self.window.flip()
+
     def on_draw( self ):
         self.render()
 
         # render the fps
         self.fps_display.draw()
 
-        # display the frame buffer
-        self.window.flip()
-
     def set_gl_state( self ):
         # enable z buffer
         glEnable( GL_DEPTH_TEST )

examples/mesh_md2/main.py

@@ -201,15 +201,15 @@ def step( self, dt ):
         # manually dispatch the on_draw event
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
+        
+        # display the frame buffer
+        self.window.flip()
 
     def on_draw( self ):
         self.render()
 
         # render the fps
         self.fps_display.draw()
-        
-        # display the frame buffer
-        self.window.flip()
 
     def set_gl_state( self ):
         # enable z buffer

examples/mesh_obj/main.py

@@ -130,16 +130,16 @@ def step( self, dt ):
         # manually dispatch the on_draw event
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
+        
+        # display the frame buffer
+        self.window.flip()
 
     def on_draw( self ):
         # render the scene
         self.render()
 
         # render the fps
         self.fps_display.draw()
-        
-        # display the frame buffer
-        self.window.flip()
 
     def initialise_mesh( self ):
         # load the obj mesh from the file

examples/multiple_viewports/main.py

@@ -167,16 +167,16 @@ def step( self, dt ):
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
 
+        # display the frame buffer
+        self.window.flip()
+
     def on_draw( self ):
         # render the scene
         self.render()
 
         # render the fps
         self.fps_display.draw()
 
-        # display the frame buffer
-        self.window.flip()
-
     def set_gl_state( self ):
         # enable z buffer
         glEnable( GL_DEPTH_TEST )

examples/orthographic/main.py

@@ -131,16 +131,16 @@ def step( self, dt ):
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
 
+        # display the frame buffer
+        self.window.flip()
+
     def on_draw( self ):
         # render the scene
         self.render()
 
         # render the fps
         self.fps_display.draw()
 
-        # display the frame buffer
-        self.window.flip()
-
     def set_gl_state( self ):
         # enable z buffer
         glEnable( GL_DEPTH_TEST )

examples/ray_casting/main.py

@@ -226,6 +226,9 @@ def step( self, dt ):
         # manually dispatch the on_draw event
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
+        
+        # display the frame buffer
+        self.window.flip()
 
     def on_draw( self ):
         # render the scene
@@ -236,9 +239,6 @@ def on_draw( self ):
 
         # render our help text
         self.help_label.draw()
-        
-        # display the frame buffer
-        self.window.flip()
 
     def set_gl_state( self ):
         # enable z buffer

examples/render_callbacks/main.py

@@ -153,15 +153,15 @@ def step( self, dt ):
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
 
+        # display the frame buffer
+        self.window.flip()
+
     def on_draw( self ):
         self.render()
 
         # render the fps
         self.fps_display.draw()
 
-        # display the frame buffer
-        self.window.flip()
-
     def render( self ):
         #
         # setup

examples/render_methods/main.py

@@ -218,6 +218,9 @@ def step( self, dt ):
         # manually dispatch the on_draw event
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
+        
+        # display the frame buffer
+        self.window.flip()
 
     def on_draw( self ):
         # render the scene
@@ -231,9 +234,6 @@ def on_draw( self ):
 
         # render our status text
         self.status_label.draw()
-        
-        # display the frame buffer
-        self.window.flip()
 
     def on_key_event( self, digital, event, key ):
         if event == Keyboard.up:

examples/scene_graph/main.py

@@ -132,15 +132,15 @@ def step( self, dt ):
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
 
+        # display the frame buffer
+        self.window.flip()
+
     def on_draw( self ):
         self.render()
 
         # render the fps
         self.fps_display.draw()
 
-        # display the frame buffer
-        self.window.flip()
-
     def set_gl_state( self ):
         # enable z buffer
         glEnable( GL_DEPTH_TEST )

examples/six_dof_camera/main.py

@@ -224,6 +224,9 @@ def step( self, dt ):
         # manually dispatch the on_draw event
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
+        
+        # display the frame buffer
+        self.window.flip()
 
     def on_draw( self ):
         # render the scene
@@ -234,9 +237,6 @@ def on_draw( self ):
 
         # render the fps
         self.fps_display.draw()
-        
-        # display the frame buffer
-        self.window.flip()
 
     def render( self ):
         #

examples/sorting/main.py

@@ -234,6 +234,9 @@ def step( self, dt ):
         # manually dispatch the on_draw event
         # as we patched it out of the idle loop
         self.window.dispatch_event( 'on_draw' )
+        
+        # display the frame buffer
+        self.window.flip()
 
     def on_draw( self ):
         # render the scene
@@ -249,9 +252,6 @@ def on_draw( self ):
         self.setup_status_text()
         # render it
         self.status_label.draw()
-        
-        # display the frame buffer
-        self.window.flip()
 
     def on_key_event( self, digital, event, key ):
         if event == Keyboard.up: