use non-deprecated libmodulemd functions

Author: Martin Hatina

dnf/base.py

@@ -261,7 +261,7 @@ def _setup_modules(self):
                 try:
                     with open(yaml_file, "r") as f:
                         modules_yaml = f.read()
-                    module_metadata = Modulemd.Module.new_all_from_string_ext(modules_yaml)
+                    module_metadata = Modulemd.objects_from_string(modules_yaml)
                     defaults = [i for i in module_metadata if isinstance(i, Modulemd.Defaults)]
                     module_defaults_prioritizer.add(defaults, 1000)
                 except IOError as ex:

dnf/module/repo_module_dict.py

@@ -349,7 +349,7 @@ def get_best_versions(self, module_specs):
                     default_stream = module_version.repo_module.defaults.peek_default_stream()
                     profile_defaults = module_version.repo_module.defaults.peek_profile_defaults()
                     if default_stream in profile_defaults:
-                        default_profiles.extend(profile_defaults[default_stream].get())
+                        default_profiles.extend(profile_defaults[default_stream].dup())
 
                 if best_version < module_version:
                     logger.info(module_messages[INSTALLING_NEWER_VERSION].format(best_version,
@@ -364,7 +364,7 @@ def get_best_versions(self, module_specs):
                 default_stream = module_version.repo_module.defaults.peek_default_stream()
                 profile_defaults = module_version.repo_module.defaults.peek_profile_defaults()
                 if default_stream in profile_defaults:
-                    default_profiles.extend(profile_defaults[default_stream].get())
+                    default_profiles.extend(profile_defaults[default_stream].dup())
 
                 if module_form.profile:
                     profiles = [module_form.profile]
@@ -513,7 +513,7 @@ def get_info(self, module_spec):
         default_stream = module_version.repo_module.defaults.peek_default_stream()
         profile_defaults = module_version.repo_module.defaults.peek_profile_defaults()
         if default_stream in profile_defaults:
-            default_profiles.extend(profile_defaults[default_stream].get())
+            default_profiles.extend(profile_defaults[default_stream].dup())
 
         lines = OrderedDict()
         lines["Name"] = module_version.name

dnf/module/repo_module_version.py

@@ -35,7 +35,7 @@ def __lt__(self, other):
         assert self.full_stream == other.full_stream
         if self.repo_module.conf.locked._get():
             return self.version < self.repo_module.conf.version._get()
-        return self.module_metadata.get_version() < other.module_metadata.get_version()
+        return self.module_metadata.peek_version() < other.module_metadata.peek_version()
 
     def __repr__(self):
         return self.full_version
@@ -139,7 +139,7 @@ def remove(self, profiles):
                                              profiles=sorted(set(profiles)))
 
     def artifacts(self):
-        return self.module_metadata.get_rpm_artifacts().get()
+        return self.module_metadata.peek_rpm_artifacts().dup()
 
     def requires(self):
         requires = {}
@@ -149,17 +149,17 @@ def requires(self):
         return requires
 
     def summary(self):
-        return self.module_metadata.get_summary()
+        return self.module_metadata.peek_summary()
 
     def description(self):
-        return self.module_metadata.get_description()
+        return self.module_metadata.peek_description()
 
     @staticmethod
     def nevra_object_to_nevr_str(nevra_object):
         return "{}-{}".format(nevra_object.name, nevra_object.evr())
 
     def rpms(self, profile):
-        return self.module_metadata.get_profiles()[profile].get_rpms().get()
+        return self.module_metadata.peek_profiles()[profile].peek_rpms().dup()
 
     def profile_nevra_objects(self, profile):
         result = []
@@ -174,26 +174,26 @@ def profile_nevra_objects(self, profile):
 
     @property
     def version(self):
-        return self.module_metadata.get_version()
+        return self.module_metadata.peek_version()
 
     @property
     def full_version(self):
         return "%s:%s:%s" % (
-            self.module_metadata.get_name(), self.module_metadata.get_stream(),
-            self.module_metadata.get_version())
+            self.module_metadata.peek_name(), self.module_metadata.peek_stream(),
+            self.module_metadata.peek_version())
 
     @property
     def stream(self):
-        return self.module_metadata.get_stream()
+        return self.module_metadata.peek_stream()
 
     @property
     def full_stream(self):
-        return "%s-%s" % (self.module_metadata.get_name(), self.module_metadata.get_stream())
+        return "%s-%s" % (self.module_metadata.peek_name(), self.module_metadata.peek_stream())
 
     @property
     def name(self):
-        return self.module_metadata.get_name()
+        return self.module_metadata.peek_name()
 
     @property
     def profiles(self):
-        return sorted(self.module_metadata.get_profiles())
+        return sorted(self.module_metadata.peek_profiles())

tests/modules/specs/_create_modulemd.py

@@ -73,7 +73,7 @@ def parse_module_id(module_id):
         sset.add("LGPLv2")
         mmd.set_module_licenses(sset)
         mmd.set_summary("Fake module")
-        mmd.set_description(mmd.get_summary())
+        mmd.set_description(mmd.peek_summary())
         artifacts = Modulemd.SimpleSet()
         for rpm in rpms:
             artifacts.add(rpm[:-4])

tests/test_modules.py

@@ -201,7 +201,7 @@ def _create_mmd(name, stream, version, rpms=None, profiles=None):
         sset.add("LGPLv2")
         mmd.set_module_licenses(sset)
         mmd.set_summary(str("Fake module"))
-        mmd.set_description(mmd.get_summary())
+        mmd.set_description(mmd.peek_summary())
         artifacts = Modulemd.SimpleSet()
         for rpm in rpms:
             artifacts.add(rpm[:-4])