322: Nicer handling for no jobs (#466)

## Status

- Related to
RaspberryPiFoundation/digital-editor-issues#322

## What's changed?

- Improve handling where no jobs are found

## Steps to perform after deploying to production

N/A

Author: danhalson

app/controllers/api/school_students_controller.rb

@@ -37,7 +37,8 @@ def create_batch
       )
 
       if result.success?
-        head :accepted
+        @job_id = result[:job_id]
+        render :create_batch, formats: [:json], status: :accepted
       else
         render json: { error: result[:error] }, status: :unprocessable_entity
       end

app/controllers/api/user_jobs_controller.rb

@@ -6,7 +6,7 @@ class UserJobsController < ApiController
 
     def index
       user_jobs = UserJob.where(user_id: current_user.id).includes(:good_job)
-      jobs = user_jobs.map { |user_job| job_attributes(user_job.good_job) }
+      jobs = user_jobs&.map { |user_job| job_attributes(user_job&.good_job) }
       if jobs.any?
         render json: { jobs: }, status: :ok
       else
@@ -16,8 +16,8 @@ def index
 
     def show
       user_job = UserJob.find_by(good_job_id: params[:id], user_id: current_user.id)
-      job = job_attributes(user_job.good_job)
-      if job
+      job = job_attributes(user_job&.good_job) unless user_job.nil?
+      if job.present?
         render json: { job: }, status: :ok
       else
         render json: { error: 'Job not found' }, status: :not_found

app/views/api/school_students/create_batch.json.jbuilder

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+json.job_id @job_id

lib/concepts/school_student/create_batch.rb

@@ -30,6 +30,11 @@ def call(school:, school_students_params:, token:, user_id:)
       private
 
       def create_batch(school, students, token, user_id)
+        # Ensure that nil values are empty strings, else Profile will swallow validations
+        students = students.map do |student|
+          student.transform_values { |value| value.nil? ? '' : value }
+        end
+
         validate(school:, students:, token:)
 
         job = CreateStudentsJob.attempt_perform_later(school_id: school.id, students:, token:, user_id:)
@@ -45,7 +50,7 @@ def validate(school:, students:, token:)
 
       def decrypt_students(students)
         students.deep_dup.each do |student|
-          student[:password] = DecryptionHelpers.decrypt_password(student[:password])
+          student[:password] = DecryptionHelpers.decrypt_password(student[:password]) if student[:password].present?
         end
       end