Pass School instance to SchoolVerificationService

This feels more idiomatic.

I don't understand why RuboCop is now complaining about the
Metrics/AbcSize of `SchoolVerificationService#verify`.

Author: chrisroos

app/controllers/admin/schools_controller.rb

@@ -3,29 +3,29 @@
 module Admin
   class SchoolsController < Admin::ApplicationController
     def verify
-      school_id = params[:id]
-      service = SchoolVerificationService.new(school_id)
+      school = School.find(params[:id])
+      service = SchoolVerificationService.new(school)
 
       if service.verify
         flash[:notice] = t('administrate.controller.verify_school.success')
       else
         flash[:error] = t('administrate.controller.verify_school.error')
       end
 
-      redirect_to admin_school_path(id: school_id)
+      redirect_to admin_school_path(school)
     end
 
     def reject
-      school_id = params[:id]
-      service = SchoolVerificationService.new(school_id)
+      school = School.find(params[:id])
+      service = SchoolVerificationService.new(school)
 
       if service.reject
         flash[:notice] = t('administrate.controller.reject_school.success')
       else
         flash[:error] = t('administrate.controller.reject_school.error')
       end
 
-      redirect_to admin_school_path(id: school_id)
+      redirect_to admin_school_path(school)
     end
 
     def default_sorting_attribute

app/services/school_verification_service.rb

@@ -1,15 +1,16 @@
 # frozen_string_literal: true
 
 class SchoolVerificationService
-  def initialize(school_id)
-    @school_id = school_id
+  attr_reader :school
+
+  def initialize(school)
+    @school = school
   end
 
+  # rubocop:disable Metrics/AbcSize
   def verify
     School.transaction do
-      school = School.find(@school_id)
       school.update!(verified_at: Time.zone.now, rejected_at: nil)
-
       Role.owner.create(user_id: school.creator_id, school:)
       Role.teacher.create(user_id: school.creator_id, school:)
     end
@@ -20,9 +21,9 @@ def verify
   else
     true
   end
+  # rubocop:enable Metrics/AbcSize
 
   def reject
-    school = School.find(@school_id)
     school.update(verified_at: nil, rejected_at: Time.zone.now)
   end
 end

lib/tasks/classroom_management_helper.rb

@@ -25,7 +25,7 @@ def create_school(creator_id, school_id = nil)
 
   def verify_school(school)
     Rails.logger.info 'Verifying the school...'
-    SchoolVerificationService.new(school.id).verify
+    SchoolVerificationService.new(school).verify
   end
 
   def create_school_class(teacher_id, school)

spec/features/admin/schools_spec.rb

@@ -73,7 +73,7 @@
 
     before do
       stub_user_info_api_for(creator)
-      allow(SchoolVerificationService).to receive(:new).with(school.id).and_return(verification_service)
+      allow(SchoolVerificationService).to receive(:new).with(school).and_return(verification_service)
 
       post verify_admin_school_path(school)
     end
@@ -115,7 +115,7 @@
 
     before do
       stub_user_info_api_for(creator)
-      allow(SchoolVerificationService).to receive(:new).with(school.id).and_return(verification_service)
+      allow(SchoolVerificationService).to receive(:new).with(school).and_return(verification_service)
 
       patch reject_admin_school_path(school)
     end

spec/services/school_verification_service_spec.rb

@@ -6,7 +6,7 @@
   let(:school) { create(:school, creator_id: school_creator.id) }
   let(:user) { create(:user) }
   let(:school_creator) { create(:user) }
-  let(:service) { described_class.new(school.id) }
+  let(:service) { described_class.new(school) }
   let(:organisation_id) { SecureRandom.uuid }
 
   describe '#verify' do
@@ -55,18 +55,6 @@
         expect(service.verify).to be(false)
       end
     end
-
-    describe 'when the school cannot be found' do
-      before do
-        allow(Sentry).to receive(:capture_exception)
-        allow(School).to receive(:find).with(school.id).and_raise(ActiveRecord::RecordNotFound)
-        service.verify
-      end
-
-      it 'reports the error in Sentry' do
-        expect(Sentry).to have_received(:capture_exception)
-      end
-    end
   end
 
   describe '#reject' do