Extract School#reject

To complement `School#verify!`. Note that this doesn't need to be a bang
method because the return value of calling `update` is passed through
`SchoolVerificationService#reject` and back to
`Admin::SchoolsController#reject`. The `School#verify!` method needs to
raise on error so that it triggers a transaction rollback in
`SchoolVerificationService#verify`.

Author: chrisroos

app/models/school.rb

@@ -47,6 +47,10 @@ def verify!
     update!(verified_at: Time.zone.now)
   end
 
+  def reject
+    update(rejected_at: Time.zone.now)
+  end
+
   private
 
   # Ensure the reference is nil, not an empty string

app/services/school_verification_service.rb

@@ -23,7 +23,5 @@ def verify
   end
   # rubocop:enable Metrics/AbcSize
 
-  def reject
-    school.update(verified_at: nil, rejected_at: Time.zone.now)
-  end
+  delegate :reject, to: :school
 end

spec/models/school_spec.rb

@@ -180,12 +180,12 @@
 
     it 'cannot have #rejected_at set when #verified_at is present' do
       school.verify!
-      school.update(rejected_at: Time.zone.now)
+      school.reject
       expect(school.errors[:rejected_at]).to include('must be blank')
     end
 
     it 'cannot have #verified_at set when #rejected_at is present' do
-      school.update!(rejected_at: Time.zone.now)
+      school.reject
       school.update(verified_at: Time.zone.now)
       expect(school.errors[:verified_at]).to include('must be blank')
     end
@@ -197,7 +197,7 @@
     end
 
     it "cannot change #rejected_at once it's been set" do
-      school.update!(rejected_at: Time.zone.now)
+      school.reject
       school.update(rejected_at: nil)
       expect(school.errors[:rejected_at]).to include('cannot be changed after rejection')
     end
@@ -281,4 +281,20 @@
       expect { school.verify! }.to raise_error(ActiveRecord::RecordInvalid)
     end
   end
+
+  describe '#reject' do
+    it 'sets rejected_at to the current time' do
+      school.reject
+      expect(school.rejected_at).to be_within(1.second).of(Time.zone.now)
+    end
+
+    it 'returns true on successful rejection' do
+      expect(school.reject).to be(true)
+    end
+
+    it 'returns false on unsuccessful rejection' do
+      school.verified_at = Time.zone.now
+      expect(school.reject).to be(false)
+    end
+  end
 end