Skip to content

Commit 3a5872d

Browse files
committed
tidying
1 parent 8f0b208 commit 3a5872d

File tree

2 files changed

+5
-27
lines changed

2 files changed

+5
-27
lines changed

app/controllers/api/lessons_controller.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ def create_copy
4444
def create_from_project
4545
remix_origin = request.origin || request.referer
4646

47-
puts("lesson_params: #{lesson_params}")
48-
49-
result = Lesson::CreateFromProject.call(lesson_params: lesson_params, remix_origin:)
47+
result = Lesson::CreateFromProject.call(lesson_params:, remix_origin:)
5048

5149
if result.success?
5250
@lesson_with_user = result[:lesson].with_user

lib/concepts/lesson/operations/create_from_project.rb

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,48 +4,28 @@ class Lesson
44
class CreateFromProject
55
class << self
66
def call(lesson_params:, remix_origin:)
7-
pp 'creating lesson from project!'
8-
# ActiveRecord::Base.transaction do
97
response = OperationResponse.new
108
response[:lesson] = build_lesson_from_project(lesson_params, remix_origin)
119
response[:lesson].save!
1210
response
1311
rescue StandardError => e
1412
Sentry.capture_exception(e)
15-
pp(e)
1613
errors = response[:lesson].errors.full_messages.join(',')
1714
response[:error] = "Error creating remix of lesson: #{errors}"
1815
response
19-
# end
2016
end
2117

2218
private
2319

24-
def build_lesson_from_project(lesson_params, remix_origin)
25-
# original_project = Project.find_by(identifier: lesson_params[:project_identifier])
26-
# lesson_copy = Lesson.new(name: original_project.name)
27-
# filtered_params = lesson_params.except(:project_identifier)
28-
# lesson_copy.assign_attributes(filtered_params)
29-
# lesson_copy.project = build_project_remix(original_project, lesson_params, remix_origin)
30-
31-
# lesson_copy
20+
def build_lesson_from_project(lesson_params, _remix_origin)
3221
project = Project.find_by(identifier: lesson_params[:project_identifier])
3322
lesson = Lesson.new(
34-
name: project.name)
23+
name: project.name
24+
)
3525
lesson.assign_attributes(lesson_params.except(:project_identifier))
3626
lesson.project = project
3727
lesson
3828
end
39-
40-
# def build_project_remix(original_project, lesson_params, remix_origin)
41-
# response = Project::CreateRemix.call(
42-
# params: {school_id: lesson_params[:school_id]},
43-
# user_id: lesson_params[:user_id],
44-
# original_project: original_project,
45-
# remix_origin: remix_origin
46-
# )
47-
# response[:project]
48-
# end
4929
end
5030
end
51-
end
31+
end

0 commit comments

Comments
 (0)