Get student name with project (#413)

## Status

- Closes _add issue numbers or delete_
- Related to _add issue numbers or delete_

## Points for consideration:

- Security
- Performance

## What's changed?

_Description of what's been done - bullets are often best_

## Steps to perform after deploying to production

_If the production environment requires any extra work after this PR has
been deployed detail it here. This could be running a Rake task, a
migration, or upgrading a Gem. That kind of thing._

Author: loiswells97

app/controllers/api/projects_controller.rb

@@ -17,6 +17,11 @@ def index
     end
 
     def show
+      if !@project.school_id.nil? && @project.lesson_id.nil?
+        project_with_user = @project.with_user(@current_user)
+        @user = project_with_user[1]
+      end
+
       render :show, formats: [:json]
     end
 

app/models/project.rb

@@ -32,9 +32,9 @@ def self.with_users(current_user)
   end
 
   def with_user(current_user)
-    school = School.find_by(id: :school_id)
+    school = School.find_by(id: school_id)
     students = SchoolStudent::List.call(school:, token: current_user.token,
-                                        student_ids: [:user_id])[:school_students] || []
+                                        student_ids: [user_id])[:school_students] || []
     [self, students.first]
   end
 

app/views/api/projects/show.json.jbuilder

@@ -29,3 +29,5 @@ json.image_list(@project.images) do |image|
   json.filename(image.filename)
   json.url(rails_blob_url(image))
 end
+
+json.user_name(@user&.name) if @user.present?

spec/requests/projects/show_spec.rb

@@ -3,30 +3,32 @@
 require 'rails_helper'
 
 RSpec.describe 'Project show requests' do
-  let!(:project) { create(:project, user_id: owner.id, locale: nil) }
-  let(:project_json) do
-    {
-      identifier: project.identifier,
-      project_type: 'python',
-      locale: project.locale,
-      name: project.name,
-      user_id: project.user_id,
-      components: [],
-      image_list: []
-    }.to_json
-  end
   let(:headers) { {} }
-  let(:owner) { create(:owner, school:) }
+  let(:teacher) { create(:teacher, school:) }
   let(:school) { create(:school) }
 
   context 'when user is logged in' do
     let(:headers) { { Authorization: UserProfileMock::TOKEN } }
 
     before do
-      authenticated_in_hydra_as(owner)
+      authenticated_in_hydra_as(teacher)
+      stub_profile_api_list_school_students(school:, student_attributes: [{ name: 'Joe Bloggs' }])
     end
 
     context 'when loading own project' do
+      let!(:project) { create(:project, user_id: teacher.id, locale: nil) }
+      let(:project_json) do
+        {
+          identifier: project.identifier,
+          project_type: 'python',
+          locale: project.locale,
+          name: project.name,
+          user_id: project.user_id,
+          components: [],
+          image_list: []
+        }.to_json
+      end
+
       it 'returns success response' do
         get("/api/projects/#{project.identifier}", headers:)
 
@@ -44,6 +46,39 @@
       end
     end
 
+    context 'when loading a student\'s project' do
+      let(:student) { create(:student, school:) }
+      let(:lesson) { build(:lesson, school:, user_id: teacher.id, visibility: 'students') }
+      let(:teacher_project) { create(:project, school_id: school.id, lesson_id: lesson.id, user_id: teacher.id, locale: nil) }
+      let!(:student_project) { create(:project, school_id: school.id, lesson_id: nil, user_id: student.id, remixed_from_id: teacher_project.id, locale: nil) }
+      let(:student_project_json) do
+        {
+          identifier: student_project.identifier,
+          project_type: 'python',
+          locale: student_project.locale,
+          name: student_project.name,
+          user_id: student_project.user_id,
+          parent: {
+            name: teacher_project.name,
+            identifier: teacher_project.identifier
+          },
+          components: [],
+          image_list: [],
+          user_name: 'Joe Bloggs'
+        }.to_json
+      end
+
+      it 'returns success response' do
+        get("/api/projects/#{student_project.identifier}", headers:)
+        expect(response).to have_http_status(:ok)
+      end
+
+      it 'includes the student\'s name in the project json' do
+        get("/api/projects/#{student_project.identifier}", headers:)
+        expect(response.body).to eq(student_project_json)
+      end
+    end
+
     context 'when loading another user\'s project' do
       let!(:another_project) { create(:project, user_id: SecureRandom.uuid, locale: nil) }
       let(:another_project_json) do
@@ -115,6 +150,19 @@
     end
 
     context 'when loading an owned project' do
+      let!(:project) { create(:project, user_id: teacher.id, locale: nil) }
+      let(:project_json) do
+        {
+          identifier: project.identifier,
+          project_type: 'python',
+          locale: project.locale,
+          name: project.name,
+          user_id: project.user_id,
+          components: [],
+          image_list: []
+        }.to_json
+      end
+
       it 'returns forbidden response' do
         get("/api/projects/#{project.identifier}", headers:)