rubocop

Author: Scott Adams

app/models/project.rb

@@ -80,7 +80,7 @@ def user_has_a_role_within_the_school
   end
 
   def user_is_a_member_or_the_owner_of_the_lesson
-    return if !lesson || user_id == lesson.user_id || (lesson.school_class && lesson.school_class.members.exists?(student_id: user_id))
+    return if !lesson || user_id == lesson.user_id || lesson.school_class&.members&.exists?(student_id: user_id)
 
     errors.add(:user, "'#{user_id}' is not the owner or a member of the lesson '#{lesson_id}'")
   end

spec/features/lesson/updating_a_lesson_spec.rb

@@ -3,11 +3,6 @@
 require 'rails_helper'
 
 RSpec.describe 'Updating a lesson', type: :request do
-  before do
-    authenticated_in_hydra_as(owner)
-    stub_user_info_api_for(teacher)
-  end
-
   let(:headers) { { Authorization: UserProfileMock::TOKEN } }
   let(:params) do
     {
@@ -23,6 +18,8 @@
   let(:project) { create(:project) }
 
   before do
+    authenticated_in_hydra_as(owner)
+    stub_user_info_api_for(teacher)
     lesson
     project.update!(lesson:, school:, user_id: lesson.user_id, identifier: 'something')
   end