lots of test fixing

Author: loiswells97

app/controllers/api/lessons_controller.rb

@@ -61,7 +61,7 @@ def create_from_project
     def update
       # TODO: Consider removing user_id from the lesson_params for update so users can update other users' lessons without changing ownership
       # OR consider dropping user_id on lessons and using teacher id/ids on the class instead
-      result = Lesson::Update.call(lesson: @lesson, lesson_params:)
+      result = Lesson::Update.call(lesson: @lesson, lesson_params: base_params)
 
       if result.success?
         @lesson_with_user = result[:lesson].with_user

spec/factories/lesson.rb

@@ -6,7 +6,7 @@
     sequence(:name) { |n| "Lesson #{n}" }
     description { 'Description' }
     visibility { 'teachers' }
-    project { create(:project, user_id:, name:, school: school || school_class&.school) }
+    project { create(:project, user_id:, name:, school_id: school_id || school&.id || school_class&.school&.id) }
 
     trait :with_project_components do
       transient do

spec/features/lesson/archiving_a_lesson_spec.rb

@@ -44,7 +44,7 @@
   end
 
   it "responds 403 Forbidden when the user is not the lesson's owner" do
-    lesson.update!(user_id: SecureRandom.uuid)
+    authenticated_in_hydra_as(teacher)
 
     delete("/api/lessons/#{lesson.id}", headers:)
     expect(response).to have_http_status(:forbidden)

spec/features/lesson/updating_a_lesson_spec.rb

@@ -12,6 +12,7 @@
     }
   end
   let!(:lesson) { create(:lesson, name: 'Test Lesson', user_id: owner.id) }
+  let(:teacher_lesson) { create(:lesson, name: 'Test Teacher Lesson', user_id: teacher.id) }
   let(:teacher) { create(:teacher, school:) }
   let(:school) { create(:verified_school) }
   let(:owner) { create(:owner, school:, name: 'School Owner') }
@@ -51,9 +52,7 @@
   end
 
   it "responds 403 Forbidden when the user is not the lesson's owner" do
-    lesson.update!(user_id: SecureRandom.uuid)
-
-    put("/api/lessons/#{lesson.id}", headers:, params:)
+    put("/api/lessons/#{teacher_lesson.id}", headers:, params:)
     expect(response).to have_http_status(:forbidden)
   end