Extract School#verified?

To remove some duplication.

Author: chrisroos

app/controllers/admin/schools_controller.rb

@@ -5,9 +5,9 @@ class SchoolsController < Admin::ApplicationController
     def authorized_action?(resource, action)
       case action
       when :verify_school
-        resource&.rejected_at.present? || resource&.verified_at.nil?
+        resource&.rejected_at.present? || !resource&.verified?
       when :reject_school
-        resource&.verified_at.present? || resource&.rejected_at.nil?
+        resource&.verified? || resource&.rejected_at.nil?
       else
         super
       end

app/models/school.rb

@@ -31,6 +31,10 @@ def creator
     User.from_userinfo(ids: creator_id).first
   end
 
+  def verified?
+    verified_at.present?
+  end
+
   private
 
   # Ensure the reference is nil, not an empty string

app/models/teacher_invitation.rb

@@ -16,7 +16,7 @@ class TeacherInvitation < ApplicationRecord
   private
 
   def school_is_verified
-    return if school.verified_at
+    return if school.verified?
 
     errors.add(:school, 'is not verified')
   end

lib/concepts/school_owner/invite.rb

@@ -18,7 +18,7 @@ def call(school:, school_owner_params:, token:)
       def invite_owner(school, school_owner_params, token)
         email_address = school_owner_params.fetch(:email_address)
 
-        raise ArgumentError, 'school is not verified' unless school.verified_at
+        raise ArgumentError, 'school is not verified' unless school.verified?
         raise ArgumentError, "email address '#{email_address}' is invalid" unless EmailValidator.valid?(email_address)
 
         ProfileApiClient.invite_school_owner(token:, email_address:, organisation_id: school.id)

lib/concepts/school_student/create.rb

@@ -27,7 +27,7 @@ def create_student(school, school_student_params, token)
       end
 
       def validate(school:, username:, password:, name:)
-        raise ArgumentError, 'school is not verified' unless school.verified_at
+        raise ArgumentError, 'school is not verified' unless school.verified?
         raise ArgumentError, "username '#{username}' is invalid" if username.blank?
         raise ArgumentError, "password '#{password}' is invalid" if password.size < 8
         raise ArgumentError, "name '#{name}' is invalid" if name.blank?

lib/concepts/school_student/create_batch.rb

@@ -30,7 +30,7 @@ def create_batch(school, uploaded_file, token)
       def validate(school:, sheet:)
         expected_header = ['Student Name', 'Username', 'Password']
 
-        raise ArgumentError, 'school is not verified' unless school.verified_at
+        raise ArgumentError, 'school is not verified' unless school.verified?
         raise ArgumentError, 'the spreadsheet header row is invalid' unless sheet.row(1) == expected_header
 
         @errors = []

spec/models/school_spec.rb

@@ -217,4 +217,16 @@
       expect { described_class.find_for_user!(user) }.to raise_error(ActiveRecord::RecordNotFound)
     end
   end
+
+  describe '#verified?' do
+    it 'returns true when verified_at is present' do
+      school.verified_at = Time.zone.now
+      expect(school).to be_verified
+    end
+
+    it 'returns false when verified_at is blank' do
+      school.verified_at = nil
+      expect(school).not_to be_verified
+    end
+  end
 end