Make verify/reject member routes of school

This feels more idiomatic as these actions operate on a single school.

Author: chrisroos

app/controllers/admin/schools_controller.rb

@@ -3,7 +3,7 @@
 module Admin
   class SchoolsController < Admin::ApplicationController
     def verify_school
-      school_id = params[:school_id]
+      school_id = params[:id]
       service = SchoolVerificationService.new(school_id)
 
       if service.verify
@@ -16,7 +16,7 @@ def verify_school
     end
 
     def reject_school
-      school_id = params[:school_id]
+      school_id = params[:id]
       service = SchoolVerificationService.new(school_id)
 
       if service.reject

app/views/admin/schools/show.html.erb

@@ -32,7 +32,7 @@ as well as a link to its edit page.
 
     <%= link_to(
       t("administrate.actions.verify_school"),
-      admin_school_verify_school_path(page.resource),
+      verify_school_admin_school_path(page.resource),
       class: "button button--verify",
       method: :post,
       style: "background-color: green; margin: 5px;",
@@ -41,7 +41,7 @@ as well as a link to its edit page.
 
     <%= link_to(
       t("administrate.actions.reject_school"),
-      admin_school_reject_school_path(page.resource),
+      reject_school_admin_school_path(page.resource),
       class: "button button--danger",
       method: :patch,
       style: "background-color: hsla(0, 88%, 33%, 1); margin: 5px 5px 5px 0;",

config/routes.rb

@@ -11,8 +11,10 @@
     end
 
     resources :schools, only: %i[index show edit update] do
-      post :verify_school
-      patch :reject_school
+      member do
+        post :verify_school
+        patch :reject_school
+      end
     end
 
     resources :school_classes, only: %i[show]

spec/features/admin/schools_spec.rb

@@ -75,7 +75,7 @@
       stub_user_info_api_for(creator)
       allow(SchoolVerificationService).to receive(:new).with(school.id).and_return(verification_service)
 
-      post admin_school_verify_school_path(school)
+      post verify_school_admin_school_path(school)
     end
 
     it 'redirects to school path' do
@@ -117,7 +117,7 @@
       stub_user_info_api_for(creator)
       allow(SchoolVerificationService).to receive(:new).with(school.id).and_return(verification_service)
 
-      patch admin_school_reject_school_path(school)
+      patch reject_school_admin_school_path(school)
     end
 
     it 'redirects to school path' do