Skip to content

Add flag to identify school as linked to ExCS #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danhalson opened this issue May 9, 2025 · 2 comments · Fixed by #546
Closed

Add flag to identify school as linked to ExCS #543

danhalson opened this issue May 9, 2025 · 2 comments · Fixed by #546
Assignees

Comments

@danhalson
Copy link
Contributor

danhalson commented May 9, 2025

Approach

A value identifying the origin app will be passed from the frontend as part of the school payload, if this value is present and matches ExCS then the value should be stored against the school record.

Steps

  • Create a migration adding an enum to the schools table
    • should default to code editor for education
    • should allow an identifier for experience cs
  • Add a field to the .permit list in the school controller
  • Update the /lib/concepts/school/operations create and update endpoints
  • Ensure value is returned in the views /app/views/schools/

Expected tests...

  • Against the model: models/school_spec.rb
  • Ensuring the field is returned by the api: features/school/showing_a_school_spec.rb
  • Ensuring the field is updated by the api: features/school/creating_a_school_spec.rb
  • Ensuring the field is created by the api: features/school/creating_a_school_spec.rb
  • Any others that may be relevant...
@danhalson danhalson self-assigned this May 15, 2025
Copy link
Contributor

Copy link
Contributor

Could not create PR (Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between main and issues/543-Add_flag_to_identify_school_as_linked_to_ExCS"} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request)

@danhalson danhalson reopened this May 19, 2025
danhalson added a commit that referenced this issue May 24, 2025
## Status

- Closes #543

## Points for consideration:

- Security
- Performance

## What's changed?

- Adds `user_origin` enum to capture user origin
- Adds a school template to make views more DRY

## Steps to perform after deploying to production

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant